Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize obstacles with less vertices, connect shapes and set new bridges' gaps #991

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Nico-Sanchez
Copy link
Collaborator

@Nico-Sanchez Nico-Sanchez commented Nov 25, 2024

Motivation

We set new bridges in the front and we need to set them in the backend.
Also, the shapes are too overfitted to its front representation, and there are gaps between them.

Summary of changes

Reorganize obstacles with less vertices, connect shapes and set new bridges' gaps

How to test it?

Play the game with the front-end branch -> https://github.com/lambdaclass/champions_of_mirra/pull/2250
Every bridge should work properly.
Only 1 bridge is a little on the left (in the front). I made this on purpose because we'll be moving it a bit to the right. We'll do that after this gets merged.

Before:

Screenshot 2024-11-22 at 7 51 37 PM

After:

Screenshot 2024-11-22 at 7 44 29 PM

Checklist

  • Tested the changes locally.
  • Reviewed the changes on GitHub, line by line.
  • This change requires new documentation.
    • Documentation has been added/updated.

tvillegas98
tvillegas98 previously approved these changes Nov 25, 2024
Copy link
Contributor

@tvillegas98 tvillegas98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! they look smoother now!

@Nico-Sanchez
Copy link
Collaborator Author

Update: I just merged a new branch of mine where I reorder and reshaped the obstacles I kept.
Update obstacles layout due to changes in frontend (

Here's a look at it:
Screenshot 2024-11-25 at 6 00 48 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants