chore(l2): forbid index slicing #1344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsocolobsky
force-pushed
the
l2/forbid-index-slicing
branch
from
25ac57b
to
6b98ba2
Compare
dsocolobsky
force-pushed
the
l2/forbid-index-slicing
branch
from
6b98ba2
to
7495c84
Compare
dsocolobsky
force-pushed
the
l2/forbid-index-slicing
branch
from
886aa6f
to
bec1413
Compare
fborello-lambda
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We should not use direct indexing
var[idx]or direct index slicingvar[0..2]and instead use safe alternatives and handle the errors.Description
indexing_slicing = "deny"was added toCargo.tomlto forbid index slicing usage.l2crateCloses #1270