Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(l2): use nonce diff in state diff #1210

Merged
merged 9 commits into from
Nov 28, 2024
Merged

Conversation

ManuelBilbao
Copy link
Contributor

Motivation

We were sending the new nonce instead of nonce diff.

Description

Use the previous block state to calculate the nonce diff.

Closes #1098

@fborello-lambda fborello-lambda marked this pull request as ready for review November 27, 2024 19:20
@fborello-lambda fborello-lambda requested a review from a team as a code owner November 27, 2024 19:20
@fborello-lambda fborello-lambda self-assigned this Nov 27, 2024
@jrchatruc jrchatruc added this pull request to the merge queue Nov 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Nov 28, 2024
@fborello-lambda fborello-lambda added this pull request to the merge queue Nov 28, 2024
Merged via the queue into main with commit 3447b46 Nov 28, 2024
12 checks passed
@fborello-lambda fborello-lambda deleted the l2_fix_nonce_state_diff branch November 28, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send nonce diffs instead of new full nonce values
3 participants