-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse floats, parse chars and strings with escape codes #84
Parse floats, parse chars and strings with escape codes #84
Conversation
edg-l
commented
Jan 19, 2024
•
edited
Loading
edited
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
==========================================
+ Coverage 69.61% 69.82% +0.21%
==========================================
Files 28 28
Lines 1379 1392 +13
==========================================
+ Hits 960 972 +12
- Misses 419 420 +1 ☔ View full report in Codecov by Sentry. |
Please remove this. We don't want to support too much magic. It should be 0.1 |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add tests as pointed out by @jrchatruc