Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testcases in concrete_driver examples includes check phase for linearity check coverage #141

Closed
wants to merge 25 commits into from

Conversation

kenarab
Copy link
Collaborator

@kenarab kenarab commented Jun 5, 2024

It can be checked in codecov we are now covering linearity_check.rs source file.

Linearity check algorithm can be aknowledged as completed when fn check_var_in_expr coverage of match statement is fully covered. It is expected to cover not with examples .con file, but manually building the conditions for coverage, as the current status of the parser is possible not to satisfy all conditions from a parsed source code.

Copy link

github-actions bot commented Jun 5, 2024

Benchmarking factorial

Compiling factorial (factorial.con)
Finished release in 30.30991ms
Running 5000000 iterations
Using input value: 20
Concrete Result = 2432902008176640000 Time taken : 59.31 ms
Rust Result = 2432902008176640000 Time taken : 60.03 ms

Benchmarking fib

Compiling fib (fib.con)
Finished release in 26.110517ms
Running 5000 iterations
Using input value: 20
Concrete Result = 6765 Time taken : 136.11 ms
Rust Result = 6765 Time taken : 85.35 ms

@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 45.71429% with 19 lines in your changes missing coverage. Please review.

Project coverage is 60.13%. Comparing base (9575fbe) to head (5bc16e4).

Files Patch % Lines
crates/concrete_driver/src/lib.rs 0.00% 15 Missing ⚠️
crates/concrete_check/src/linearity_check.rs 78.94% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
+ Coverage   54.57%   60.13%   +5.56%     
==========================================
  Files          27       27              
  Lines        5387     5381       -6     
==========================================
+ Hits         2940     3236     +296     
+ Misses       2447     2145     -302     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kenarab kenarab closed this Jun 12, 2024
@kenarab kenarab deleted the linear-checker-dev branch June 12, 2024 18:51
@kenarab
Copy link
Collaborator Author

kenarab commented Jun 12, 2024

I reopen the PR with an appealing/meaning branch, rather than a generic theme like in this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants