-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove gas accounting from AotContractExecutor #938
Open
edg-l
wants to merge
5
commits into
main
Choose a base branch
from
contract_initial_cost
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+23
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edg-l
requested review from
igaray,
azteca1998,
jrchatruc,
entropidelic,
fmoletta,
Oppen and
pefontana
as code owners
November 21, 2024 15:15
edg-l
changed the title
Add a initial_gas_cost parameter to AotContractExecutor and a helper constant (10k)
Remove gas accounting from AotContractExecutor
Nov 21, 2024
✅ Code is now correctly formatted. |
Benchmarking resultsBenchmark for program
|
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
10.998 ± 0.484 | 10.416 | 11.538 | 8.16 ± 0.36 |
cairo-native (embedded AOT) |
3.291 ± 0.012 | 3.274 | 3.312 | 2.44 ± 0.01 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
3.107 ± 0.006 | 3.100 | 3.114 | 2.31 ± 0.01 |
cairo-native (standalone AOT with -march=native) |
1.347 ± 0.002 | 1.345 | 1.351 | 1.00 |
Benchmark for program fib_2M
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
10.690 ± 0.286 | 10.352 | 11.122 | 136.91 ± 3.87 |
cairo-native (embedded AOT) |
2.872 ± 0.017 | 2.848 | 2.900 | 36.78 ± 0.40 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2.672 ± 0.015 | 2.653 | 2.698 | 34.22 ± 0.37 |
cairo-native (standalone AOT with -march=native) |
0.078 ± 0.001 | 0.077 | 0.079 | 1.00 |
Benchmark for program logistic_map
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
4.318 ± 0.061 | 4.246 | 4.411 | 17.72 ± 0.49 |
cairo-native (embedded AOT) |
3.136 ± 0.034 | 3.078 | 3.180 | 12.87 ± 0.34 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
3.077 ± 0.053 | 3.022 | 3.155 | 12.63 ± 0.37 |
cairo-native (standalone AOT with -march=native) |
0.244 ± 0.006 | 0.242 | 0.262 | 1.00 |
Benchmark results Main vs HEAD.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #938 +/- ##
==========================================
- Coverage 82.46% 82.40% -0.07%
==========================================
Files 117 117
Lines 34392 34367 -25
==========================================
- Hits 28362 28320 -42
- Misses 6030 6047 +17 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
azteca1998
approved these changes
Nov 25, 2024
gabrielbosio
approved these changes
Nov 25, 2024
FrancoGiachetta
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the initial gas cost calculations and substractions, the caller will handle it.
Checklist