-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix block workflow #882
Fix block workflow #882
Conversation
Benchmarking resultsBenchmark for program
|
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
10.996 ± 0.059 | 10.910 | 11.102 | 24.51 ± 0.14 |
cairo-native (embedded AOT) |
3.168 ± 0.021 | 3.137 | 3.202 | 7.06 ± 0.05 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
3.211 ± 0.017 | 3.178 | 3.234 | 7.16 ± 0.04 |
cairo-native (standalone AOT) |
0.675 ± 0.004 | 0.672 | 0.685 | 1.50 ± 0.01 |
cairo-native (standalone AOT with -march=native) |
0.449 ± 0.001 | 0.448 | 0.450 | 1.00 |
Benchmark for program fib_2M
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
11.014 ± 0.309 | 10.685 | 11.421 | 1361.67 ± 51.42 |
cairo-native (embedded AOT) |
2.710 ± 0.014 | 2.689 | 2.727 | 335.11 ± 8.66 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2.793 ± 0.045 | 2.746 | 2.879 | 345.33 ± 10.40 |
cairo-native (standalone AOT) |
0.008 ± 0.000 | 0.008 | 0.009 | 1.05 ± 0.03 |
cairo-native (standalone AOT with -march=native) |
0.008 ± 0.000 | 0.008 | 0.011 | 1.00 |
Benchmark for program logistic_map
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
4.325 ± 0.036 | 4.284 | 4.402 | 61.06 ± 0.61 |
cairo-native (embedded AOT) |
2.885 ± 0.026 | 2.842 | 2.931 | 40.73 ± 0.43 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
3.047 ± 0.014 | 3.022 | 3.066 | 43.02 ± 0.31 |
cairo-native (standalone AOT) |
0.115 ± 0.000 | 0.114 | 0.115 | 1.62 ± 0.01 |
cairo-native (standalone AOT with -march=native) |
0.071 ± 0.000 | 0.070 | 0.073 | 1.00 |
Benchmark results Main vs HEAD.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #882 +/- ##
=======================================
Coverage 82.82% 82.82%
=======================================
Files 120 120
Lines 34941 34941
=======================================
Hits 28941 28941
Misses 6000 6000 ☔ View full report in Codecov by Sentry. |
- name: Patch Cairo Native's version | ||
if: ${{ matrix.runner == 'native' }} | ||
run: | | ||
cd replay | ||
sed -r -i 's/cairo_native.*rev.*[0-9a-z]+./cairo_native.git", rev = "${{ github.event.pull_request.head.sha }}"/' Cargo.toml | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will only test against the default native commit on replay branch, right? We should patch de dependency to a local path, and use our current branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ow, I thought is was already being done in the main branch, I'll change it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should work now.
Checklist