Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix block workflow #882

Merged
merged 4 commits into from
Oct 28, 2024
Merged

Fix block workflow #882

merged 4 commits into from
Oct 28, 2024

Conversation

FrancoGiachetta
Copy link
Contributor

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

Copy link

github-actions bot commented Oct 25, 2024

Benchmarking results

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 10.996 ± 0.059 10.910 11.102 24.51 ± 0.14
cairo-native (embedded AOT) 3.168 ± 0.021 3.137 3.202 7.06 ± 0.05
cairo-native (embedded JIT using LLVM's ORC Engine) 3.211 ± 0.017 3.178 3.234 7.16 ± 0.04
cairo-native (standalone AOT) 0.675 ± 0.004 0.672 0.685 1.50 ± 0.01
cairo-native (standalone AOT with -march=native) 0.449 ± 0.001 0.448 0.450 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 11.014 ± 0.309 10.685 11.421 1361.67 ± 51.42
cairo-native (embedded AOT) 2.710 ± 0.014 2.689 2.727 335.11 ± 8.66
cairo-native (embedded JIT using LLVM's ORC Engine) 2.793 ± 0.045 2.746 2.879 345.33 ± 10.40
cairo-native (standalone AOT) 0.008 ± 0.000 0.008 0.009 1.05 ± 0.03
cairo-native (standalone AOT with -march=native) 0.008 ± 0.000 0.008 0.011 1.00

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 4.325 ± 0.036 4.284 4.402 61.06 ± 0.61
cairo-native (embedded AOT) 2.885 ± 0.026 2.842 2.931 40.73 ± 0.43
cairo-native (embedded JIT using LLVM's ORC Engine) 3.047 ± 0.014 3.022 3.066 43.02 ± 0.31
cairo-native (standalone AOT) 0.115 ± 0.000 0.114 0.115 1.62 ± 0.01
cairo-native (standalone AOT with -march=native) 0.071 ± 0.000 0.070 0.073 1.00

Copy link

github-actions bot commented Oct 25, 2024

Benchmark results Main vs HEAD.

Command Mean [s] Min [s] Max [s] Relative
head factorial_2M.cairo (JIT) 3.402 ± 0.033 3.349 3.445 1.03 ± 0.01
base factorial_2M.cairo (JIT) 3.336 ± 0.031 3.284 3.406 1.01 ± 0.01
head factorial_2M.cairo (AOT) 3.314 ± 0.026 3.266 3.350 1.00
base factorial_2M.cairo (AOT) 3.327 ± 0.027 3.281 3.364 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
head fib_2M.cairo (JIT) 2.921 ± 0.022 2.882 2.955 1.02 ± 0.01
base fib_2M.cairo (JIT) 2.898 ± 0.019 2.875 2.928 1.01 ± 0.01
head fib_2M.cairo (AOT) 2.893 ± 0.041 2.838 2.964 1.01 ± 0.02
base fib_2M.cairo (AOT) 2.861 ± 0.029 2.794 2.896 1.00
Command Mean [s] Min [s] Max [s] Relative
head logistic_map.cairo (JIT) 3.235 ± 0.024 3.195 3.263 1.07 ± 0.01
base logistic_map.cairo (JIT) 3.231 ± 0.046 3.178 3.332 1.07 ± 0.02
head logistic_map.cairo (AOT) 3.025 ± 0.024 2.985 3.052 1.00 ± 0.01
base logistic_map.cairo (AOT) 3.016 ± 0.018 2.989 3.041 1.00

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.82%. Comparing base (f39cb35) to head (0dd0be9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #882   +/-   ##
=======================================
  Coverage   82.82%   82.82%           
=======================================
  Files         120      120           
  Lines       34941    34941           
=======================================
  Hits        28941    28941           
  Misses       6000     6000           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

edg-l
edg-l previously approved these changes Oct 25, 2024
edg-l
edg-l previously approved these changes Oct 25, 2024
Comment on lines 84 to 89
- name: Patch Cairo Native's version
if: ${{ matrix.runner == 'native' }}
run: |
cd replay
sed -r -i 's/cairo_native.*rev.*[0-9a-z]+./cairo_native.git", rev = "${{ github.event.pull_request.head.sha }}"/' Cargo.toml

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will only test against the default native commit on replay branch, right? We should patch de dependency to a local path, and use our current branch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ow, I thought is was already being done in the main branch, I'll change it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should work now.

@FrancoGiachetta FrancoGiachetta added the review-ready A PR that is ready for review label Oct 28, 2024
@edg-l edg-l added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit e36bf30 Oct 28, 2024
29 of 30 checks passed
@edg-l edg-l deleted the fix-workflow branch October 28, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-ready A PR that is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants