Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor arrays to use a reference-counted clone-on-write implementation. #876

Closed
wants to merge 6 commits into from

Conversation

azteca1998
Copy link
Collaborator

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

Copy link

github-actions bot commented Oct 22, 2024

Benchmarking results

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 11.023 ± 0.294 10.714 11.479 24.42 ± 0.71
cairo-native (embedded AOT) 3.238 ± 0.038 3.184 3.309 7.17 ± 0.12
cairo-native (embedded JIT using LLVM's ORC Engine) 3.177 ± 0.035 3.113 3.229 7.04 ± 0.11
cairo-native (standalone AOT) 0.674 ± 0.003 0.672 0.681 1.49 ± 0.02
cairo-native (standalone AOT with -march=native) 0.451 ± 0.005 0.448 0.461 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 10.994 ± 0.284 10.645 11.398 1373.92 ± 35.99
cairo-native (embedded AOT) 2.702 ± 0.036 2.666 2.791 337.71 ± 4.79
cairo-native (embedded JIT using LLVM's ORC Engine) 2.698 ± 0.019 2.666 2.723 337.20 ± 2.86
cairo-native (standalone AOT) 0.008 ± 0.000 0.008 0.010 1.02 ± 0.02
cairo-native (standalone AOT with -march=native) 0.008 ± 0.000 0.008 0.008 1.00

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 4.271 ± 0.042 4.220 4.350 60.17 ± 0.60
cairo-native (embedded AOT) 2.846 ± 0.033 2.811 2.917 40.10 ± 0.47
cairo-native (embedded JIT using LLVM's ORC Engine) 3.081 ± 0.038 3.047 3.167 43.41 ± 0.54
cairo-native (standalone AOT) 0.112 ± 0.000 0.112 0.113 1.58 ± 0.00
cairo-native (standalone AOT with -march=native) 0.071 ± 0.000 0.071 0.072 1.00

Copy link

github-actions bot commented Oct 22, 2024

Benchmark results Main vs HEAD.

Command Mean [s] Min [s] Max [s] Relative
head factorial_2M.cairo (JIT) 3.349 ± 0.059 3.231 3.435 1.04 ± 0.02
base factorial_2M.cairo (JIT) 3.275 ± 0.022 3.251 3.322 1.01 ± 0.02
head factorial_2M.cairo (AOT) 3.287 ± 0.065 3.199 3.399 1.02 ± 0.03
base factorial_2M.cairo (AOT) 3.234 ± 0.048 3.176 3.319 1.00
Command Mean [s] Min [s] Max [s] Relative
head fib_2M.cairo (JIT) 2.880 ± 0.028 2.835 2.938 1.03 ± 0.02
base fib_2M.cairo (JIT) 2.944 ± 0.071 2.798 3.023 1.05 ± 0.03
head fib_2M.cairo (AOT) 2.808 ± 0.060 2.753 2.963 1.00
base fib_2M.cairo (AOT) 2.861 ± 0.097 2.740 3.002 1.02 ± 0.04
Command Mean [s] Min [s] Max [s] Relative
head logistic_map.cairo (JIT) 3.094 ± 0.030 3.057 3.160 1.06 ± 0.01
base logistic_map.cairo (JIT) 3.190 ± 0.074 3.099 3.323 1.09 ± 0.03
head logistic_map.cairo (AOT) 2.932 ± 0.025 2.908 2.980 1.00
base logistic_map.cairo (AOT) 2.968 ± 0.028 2.935 3.006 1.01 ± 0.01

@azteca1998 azteca1998 linked an issue Oct 24, 2024 that may be closed by this pull request
@azteca1998 azteca1998 closed this Nov 19, 2024
@azteca1998 azteca1998 deleted the make-arrays-shared-cow branch November 21, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the arrays shared with a clone-on-write mechanism.
1 participant