Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a GEP method to blockext, simply some code #873

Merged
merged 11 commits into from
Oct 28, 2024
Merged

Add a GEP method to blockext, simply some code #873

merged 11 commits into from
Oct 28, 2024

Conversation

edg-l
Copy link
Collaborator

@edg-l edg-l commented Oct 21, 2024

Related to #862

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

@edg-l edg-l added the review-ready A PR that is ready for review label Oct 21, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 70.29586% with 251 lines in your changes missing coverage. Please review.

Project coverage is 82.91%. Comparing base (e36bf30) to head (452eb53).

Files with missing lines Patch % Lines
src/libfuncs/starknet.rs 15.26% 211 Missing ⚠️
src/libfuncs/starknet/secp256.rs 92.64% 40 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #873      +/-   ##
==========================================
+ Coverage   82.82%   82.91%   +0.08%     
==========================================
  Files         120      120              
  Lines       34941    33864    -1077     
==========================================
- Hits        28941    28079     -862     
+ Misses       6000     5785     -215     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 21, 2024

Benchmarking results

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 11.140 ± 0.309 10.836 11.577 24.82 ± 0.69
cairo-native (embedded AOT) 3.136 ± 0.012 3.117 3.150 6.99 ± 0.03
cairo-native (embedded JIT using LLVM's ORC Engine) 3.178 ± 0.014 3.163 3.202 7.08 ± 0.03
cairo-native (standalone AOT) 0.676 ± 0.003 0.674 0.683 1.51 ± 0.01
cairo-native (standalone AOT with -march=native) 0.449 ± 0.001 0.448 0.450 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 11.319 ± 0.220 10.848 11.534 1412.82 ± 30.78
cairo-native (embedded AOT) 2.689 ± 0.017 2.660 2.712 335.67 ± 3.94
cairo-native (embedded JIT using LLVM's ORC Engine) 2.726 ± 0.031 2.689 2.799 340.25 ± 5.11
cairo-native (standalone AOT) 0.008 ± 0.000 0.008 0.009 1.04 ± 0.01
cairo-native (standalone AOT with -march=native) 0.008 ± 0.000 0.008 0.009 1.00

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 4.258 ± 0.032 4.223 4.332 60.21 ± 0.48
cairo-native (embedded AOT) 2.848 ± 0.019 2.823 2.889 40.28 ± 0.29
cairo-native (embedded JIT using LLVM's ORC Engine) 3.017 ± 0.013 2.999 3.036 42.67 ± 0.21
cairo-native (standalone AOT) 0.115 ± 0.000 0.114 0.115 1.62 ± 0.01
cairo-native (standalone AOT with -march=native) 0.071 ± 0.000 0.070 0.071 1.00

Copy link

github-actions bot commented Oct 21, 2024

Benchmark results Main vs HEAD.

Command Mean [s] Min [s] Max [s] Relative
head factorial_2M.cairo (JIT) 3.157 ± 0.015 3.136 3.179 1.00 ± 0.01
base factorial_2M.cairo (JIT) 3.203 ± 0.032 3.170 3.254 1.02 ± 0.01
head factorial_2M.cairo (AOT) 3.143 ± 0.031 3.102 3.210 1.00
base factorial_2M.cairo (AOT) 3.166 ± 0.043 3.123 3.275 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
head fib_2M.cairo (JIT) 2.720 ± 0.021 2.698 2.772 1.01 ± 0.01
base fib_2M.cairo (JIT) 2.732 ± 0.015 2.715 2.757 1.02 ± 0.01
head fib_2M.cairo (AOT) 2.681 ± 0.019 2.648 2.707 1.00
base fib_2M.cairo (AOT) 2.691 ± 0.020 2.669 2.737 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
head logistic_map.cairo (JIT) 3.003 ± 0.018 2.979 3.044 1.06 ± 0.01
base logistic_map.cairo (JIT) 3.020 ± 0.022 2.989 3.067 1.06 ± 0.01
head logistic_map.cairo (AOT) 2.843 ± 0.014 2.828 2.875 1.00
base logistic_map.cairo (AOT) 2.862 ± 0.025 2.816 2.899 1.01 ± 0.01

@edg-l edg-l added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit c0d417b Oct 28, 2024
29 of 30 checks passed
@edg-l edg-l deleted the gep_blockext branch October 28, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-ready A PR that is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants