Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rust to 1.82.0 #871

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Update rust to 1.82.0 #871

merged 1 commit into from
Oct 22, 2024

Conversation

edg-l
Copy link
Collaborator

@edg-l edg-l commented Oct 21, 2024

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

@edg-l edg-l added the review-ready A PR that is ready for review label Oct 21, 2024
Copy link

Benchmarking results

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 11.009 ± 0.303 10.621 11.366 23.39 ± 0.64
cairo-native (embedded AOT) 3.180 ± 0.021 3.146 3.212 6.76 ± 0.05
cairo-native (embedded JIT using LLVM's ORC Engine) 3.207 ± 0.019 3.179 3.240 6.82 ± 0.04
cairo-native (standalone AOT) 0.679 ± 0.001 0.678 0.681 1.44 ± 0.00
cairo-native (standalone AOT with -march=native) 0.471 ± 0.001 0.470 0.471 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 10.900 ± 0.332 10.525 11.399 1361.41 ± 42.87
cairo-native (embedded AOT) 2.693 ± 0.016 2.676 2.716 336.35 ± 3.35
cairo-native (embedded JIT using LLVM's ORC Engine) 2.733 ± 0.025 2.697 2.764 341.33 ± 4.15
cairo-native (standalone AOT) 0.009 ± 0.000 0.009 0.010 1.08 ± 0.02
cairo-native (standalone AOT with -march=native) 0.008 ± 0.000 0.008 0.009 1.00

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 4.276 ± 0.014 4.255 4.301 58.88 ± 0.55
cairo-native (embedded AOT) 2.886 ± 0.030 2.844 2.925 39.74 ± 0.54
cairo-native (embedded JIT using LLVM's ORC Engine) 3.108 ± 0.063 3.039 3.206 42.80 ± 0.94
cairo-native (standalone AOT) 0.112 ± 0.000 0.112 0.113 1.55 ± 0.01
cairo-native (standalone AOT with -march=native) 0.073 ± 0.001 0.072 0.075 1.00

Copy link

Benchmark results Main vs HEAD.

Command Mean [s] Min [s] Max [s] Relative
head factorial_2M.cairo (JIT) 3.185 ± 0.026 3.155 3.224 1.01 ± 0.01
base factorial_2M.cairo (JIT) 3.205 ± 0.015 3.184 3.231 1.02 ± 0.01
head factorial_2M.cairo (AOT) 3.146 ± 0.016 3.131 3.180 1.00
base factorial_2M.cairo (AOT) 3.161 ± 0.014 3.138 3.179 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
head fib_2M.cairo (JIT) 2.702 ± 0.014 2.688 2.722 1.01 ± 0.01
base fib_2M.cairo (JIT) 2.718 ± 0.022 2.696 2.770 1.01 ± 0.01
head fib_2M.cairo (AOT) 2.681 ± 0.023 2.648 2.721 1.00
base fib_2M.cairo (AOT) 2.688 ± 0.031 2.647 2.739 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
head logistic_map.cairo (JIT) 3.022 ± 0.033 2.981 3.069 1.06 ± 0.01
base logistic_map.cairo (JIT) 3.010 ± 0.017 2.986 3.032 1.06 ± 0.01
head logistic_map.cairo (AOT) 2.852 ± 0.017 2.829 2.887 1.00
base logistic_map.cairo (AOT) 2.862 ± 0.032 2.823 2.931 1.00 ± 0.01

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.83%. Comparing base (4ba9e16) to head (eee9214).

Files with missing lines Patch % Lines
src/executor.rs 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #871   +/-   ##
=======================================
  Coverage   82.83%   82.83%           
=======================================
  Files         120      120           
  Lines       35148    35148           
=======================================
  Hits        29114    29114           
  Misses       6034     6034           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edg-l edg-l added this pull request to the merge queue Oct 22, 2024
Merged via the queue into main with commit 5648031 Oct 22, 2024
15 checks passed
@edg-l edg-l deleted the upd_rust82 branch October 22, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-ready A PR that is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants