Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update controller, allow set different cpu/memory request rate. #5195

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

zzjin
Copy link
Collaborator

@zzjin zzjin commented Nov 7, 2024

No description provided.

Copy link

sweep-ai bot commented Nov 7, 2024

Hey @zzjin, here is an example of how you can ask me to improve this pull request:

@Sweep Add unit tests for the `calculateResourceRequest` function in `controllers/devbox/internal/controller/helper/devbox.go` to verify:
1. Correct calculation when CPU and memory rates are different
2. Handling of nil resource list
3. Calculation with various input values (zero, small, large)

📖 For more information on how to use Sweep, please read our documentation.

@sealos-ci-robot
Copy link
Member

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 2165
✅ Successful 483
⏳ Timeouts 9
🔀 Redirected 0
👻 Excluded 1670
❓ Unknown 0
🚫 Errors 1

Errors per input

Errors in docs/blog/zh-Hans/2024/how-to-deploy-and-configure-meilisearch-using-docker/index.md

Errors in docs/blog/en/2023/sealos-release.md

Errors in docs/blog/en/2023/what-is-sealos.md

Full action output

Full Github Actions output

@zzjin zzjin added this to the v5.0 milestone Nov 7, 2024
@lingdie lingdie merged commit 73a0093 into labring:main Nov 8, 2024
47 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants