add LastTerminatedState for devbox.

controllers/devbox/Makefile

@@ -71,6 +71,10 @@ build: ## Build manager binary.
 run: manifests generate fmt vet ## Run a controller from your host.
 	go run ./cmd/main.go
 
+.PHONY: debug
+debug:
+	go run ./cmd/main.go --debug
+
 .PHONY: docker-build
 docker-build: ## Build docker image with the manager.
 	mv bin/manager bin/controller-devbox-${TARGETARCH}

controllers/devbox/api/v1alpha1/devbox_types.go

@@ -179,6 +179,8 @@ type DevboxStatus struct {
 	CommitHistory []*CommitHistory `json:"commitHistory"`
 	// +kubebuilder:validation:Optional
 	Phase DevboxPhase `json:"phase"`
+	// +kubebuilder:validation:Optional
+	LastTerminatedState *corev1.ContainerStateTerminated `json:"lastTerminatedState"`
 }
 
 // +kubebuilder:object:root=true

controllers/devbox/config/crd/bases/devbox.sealos.io_devboxes.yaml

@@ -2768,6 +2768,38 @@ spec:
                   - time
                   type: object
                 type: array
+              lastTerminatedState:
+                description: ContainerStateTerminated is a terminated state of a container.
+                properties:
+                  containerID:
+                    description: Container's ID in the format '<type>://<container_id>'
+                    type: string
+                  exitCode:
+                    description: Exit status from the last termination of the container
+                    format: int32
+                    type: integer
+                  finishedAt:
+                    description: Time at which the container last terminated
+                    format: date-time
+                    type: string
+                  message:
+                    description: Message regarding the last termination of the container
+                    type: string
+                  reason:
+                    description: (brief) reason from the last termination of the container
+                    type: string
+                  signal:
+                    description: Signal from the last termination of the container
+                    format: int32
+                    type: integer
+                  startedAt:
+                    description: Time at which previous execution of the container
+                      started
+                    format: date-time
+                    type: string
+                required:
+                - exitCode
+                type: object
               network:
                 properties:
                   nodePort:

controllers/devbox/config/samples/test/devbox_v1alpha1_devbox.yaml

@@ -0,0 +1,44 @@
+# Copyright © 2024 sealos.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+apiVersion: devbox.sealos.io/v1alpha1
+kind: Devbox
+metadata:
+  labels:
+    app.kubernetes.io/name: devbox
+    app.kubernetes.io/managed-by: kustomize
+  name: devbox-sample
+spec:
+  state: Running
+  resource:
+    cpu: 1000m
+    memory: 1024Mi
+  runtimeRef:
+    name: go-1-22-5
+    namespace: devbox-system
+  command:
+    - /bin/bash
+  args:
+    - -c
+    - |
+      apt-get update
+      apt-get install -y tini
+      tini -- /bin/bash -c "echo 'DevBox is ready for testing'; tail -f /dev/null"
+  network:
+    type: NodePort
+    extraPorts:
+      - containerPort: 443
+        name: 'https'
+      - containerPort: 80
+        name: 'http'

controllers/devbox/config/samples/test/devbox_v1alpha1_runtime.yaml

@@ -0,0 +1,34 @@
+# Copyright © 2024 sealos.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+apiVersion: devbox.sealos.io/v1alpha1
+kind: Runtime
+metadata:
+  name: go-1-22-5
+  namespace: devbox-system
+spec:
+  classRef: go
+  version: go1.22.5
+  description: go1.22.5
+  config:
+    image: ubuntu
+    workingDir: /home/sealos/project
+    releaseCommand:
+      - /bin/bash
+      - -c
+    releaseArgs:
+      - /home/sealos/project/entrypoint.sh
+  category:
+    - ubuntu
+    - go

controllers/devbox/deploy/manifests/deploy.yaml.tmpl

@@ -2776,6 +2776,38 @@ spec:
                   - time
                   type: object
                 type: array
+              lastTerminatedState:
+                description: ContainerStateTerminated is a terminated state of a container.
+                properties:
+                  containerID:
+                    description: Container's ID in the format '<type>://<container_id>'
+                    type: string
+                  exitCode:
+                    description: Exit status from the last termination of the container
+                    format: int32
+                    type: integer
+                  finishedAt:
+                    description: Time at which the container last terminated
+                    format: date-time
+                    type: string
+                  message:
+                    description: Message regarding the last termination of the container
+                    type: string
+                  reason:
+                    description: (brief) reason from the last termination of the container
+                    type: string
+                  signal:
+                    description: Signal from the last termination of the container
+                    format: int32
+                    type: integer
+                  startedAt:
+                    description: Time at which previous execution of the container
+                      started
+                    format: date-time
+                    type: string
+                required:
+                - exitCode
+                type: object
               network:
                 properties:
                   nodePort:

controllers/devbox/internal/controller/devbox_controller.go

@@ -38,7 +38,6 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/builder"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 	"sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
-	"sigs.k8s.io/controller-runtime/pkg/handler"
 	"sigs.k8s.io/controller-runtime/pkg/log"
 	"sigs.k8s.io/controller-runtime/pkg/predicate"
 )
@@ -212,12 +211,11 @@ func (r *DevboxReconciler) syncPod(ctx context.Context, devbox *devboxv1alpha1.D
 				logger.Error(err, "get latest devbox failed")
 				return err
 			}
-			// compare devbox status with latestDevbox status
-			latestDevbox.Status.Phase = devbox.Status.Phase
-			latestDevbox.Status.DevboxPodPhase = devbox.Status.DevboxPodPhase
-			// merge commit history, up coming commit history will be added to the latest devbox
+			// update devbox status with latestDevbox status
+			logger.Info("updating devbox status")
 			logger.Info("merge commit history", "devbox", devbox.Status.CommitHistory, "latestDevbox", latestDevbox.Status.CommitHistory)
-			latestDevbox.Status.CommitHistory = helper.MergeCommitHistory(devbox, latestDevbox)
+			helper.UpdateDevboxStatus(devbox, latestDevbox)
+			logger.Info("devbox latest terminated state", "state", devbox.Status.LastTerminatedState)
 			return r.Status().Update(ctx, latestDevbox)
 		}); err != nil {
 			logger.Error(err, "sync pod failed")
@@ -257,6 +255,8 @@ func (r *DevboxReconciler) syncPod(ctx context.Context, devbox *devboxv1alpha1.D
 		case 1:
 			pod := &podList.Items[0]
 			devbox.Status.DevboxPodPhase = pod.Status.Phase
+			devbox.Status.LastTerminatedState = helper.GetLastTerminatedState(devbox, pod)
+			logger.Info("last terminated state", "state", devbox.Status.LastTerminatedState)
 			// update commit predicated status by pod status, this should be done once find a pod
 			helper.UpdatePredicatedCommitStatus(devbox, pod)
 			// pod has been deleted, handle it, next reconcile will create a new pod, and we will update commit history status by predicated status
@@ -298,6 +298,8 @@ func (r *DevboxReconciler) syncPod(ctx context.Context, devbox *devboxv1alpha1.D
 		case 1:
 			pod := &podList.Items[0]
 			devbox.Status.DevboxPodPhase = pod.Status.Phase
+			devbox.Status.LastTerminatedState = helper.GetLastTerminatedState(devbox, pod)
+			logger.Info("last terminated state", "state", devbox.Status.LastTerminatedState)
 			// update commit predicated status by pod status, this should be done once find a pod
 			helper.UpdatePredicatedCommitStatus(devbox, pod)
 			// pod has been deleted, handle it, next reconcile will create a new pod, and we will update commit history status by predicated status
@@ -576,19 +578,9 @@ func (r *DevboxReconciler) generateImageName(devbox *devboxv1alpha1.Devbox) stri
 // SetupWithManager sets up the controller with the Manager.
 func (r *DevboxReconciler) SetupWithManager(mgr ctrl.Manager) error {
 	return ctrl.NewControllerManagedBy(mgr).
-		For(&devboxv1alpha1.Devbox{}).
-		Owns(&corev1.Pod{}).
-		Owns(&corev1.Service{}).
-		Watches(
-			&corev1.Pod{},
-			handler.EnqueueRequestForOwner(mgr.GetScheme(), mgr.GetRESTMapper(), &devboxv1alpha1.Devbox{}),
-			builder.WithPredicates(predicate.And(
-				predicate.ResourceVersionChangedPredicate{},
-				predicate.NewPredicateFuncs(func(object client.Object) bool {
-					pod := object.(*corev1.Pod)
-					return pod.Labels[label.AppManagedBy] == label.DefaultManagedBy && pod.Labels[label.AppPartOf] == devboxv1alpha1.DevBoxPartOf
-				}),
-			)),
-		).
+		For(&devboxv1alpha1.Devbox{}, builder.WithPredicates(predicate.GenerationChangedPredicate{})).
+		Owns(&corev1.Pod{}, builder.WithPredicates(predicate.ResourceVersionChangedPredicate{})). // enqueue request if pod spec/status is updated
+		Owns(&corev1.Service{}, builder.WithPredicates(predicate.GenerationChangedPredicate{})).
+		Owns(&corev1.Secret{}, builder.WithPredicates(predicate.GenerationChangedPredicate{})).
 		Complete(r)
 }

controllers/devbox/internal/controller/helper/devbox.go

@@ -119,6 +119,25 @@ func UpdatePredicatedCommitStatus(devbox *devboxv1alpha1.Devbox, pod *corev1.Pod
 	}
 }
 
+func GetLastTerminatedState(devbox *devboxv1alpha1.Devbox, pod *corev1.Pod) *corev1.ContainerStateTerminated {
+	if len(pod.Status.ContainerStatuses) == 0 {
+		return nil
+	}
+	if pod.Status.ContainerStatuses[0].State.Terminated != nil {
+		return pod.Status.ContainerStatuses[0].State.Terminated
+	}
+	return devbox.Status.LastTerminatedState
+}
+
+// UpdateDevboxStatus updates the devbox status, including phase, pod phase, last terminated state and commit history, maybe we need update more fields in the future
+// TODO: move this function to devbox types.go
+func UpdateDevboxStatus(current, latest *devboxv1alpha1.Devbox) {
+	latest.Status.Phase = current.Status.Phase
+	latest.Status.DevboxPodPhase = current.Status.DevboxPodPhase
+	latest.Status.LastTerminatedState = current.Status.LastTerminatedState
+	latest.Status.CommitHistory = MergeCommitHistory(current, latest)
+}
+
 func UpdateCommitHistory(devbox *devboxv1alpha1.Devbox, pod *corev1.Pod, updateStatus bool) {
 	// update commit history, if devbox commit history missed the pod, we need add it
 	found := false