pipeline: add render custom task func #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kurator-dev canceled.
|
Xieql
force-pushed
the
render-customtask
branch
from
fc7aacd
to
b06e479
Compare
Signed-off-by: Xieql <[email protected]>
Xieql
force-pushed
the
render-customtask
branch
from
b06e479
to
a32ac44
Compare
hzxuzhonghu
reviewed
Jan 8, 2024
|
|
||
| // CustomTaskName is the name of custom task object, in case different pipeline have the same name task. | ||
| func (cfg CustomTaskConfig) CustomTaskName() string { | ||
| return cfg.TaskName + "-" + cfg.PipelineName |
There was a problem hiding this comment.
If we look at deployment->pod name generation, we may put PipelineName in front.
And also mind the length
hzxuzhonghu
approved these changes
Jan 8, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
part of #493