Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider the client root directory in the dev server path #84

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

greghunt
Copy link

@greghunt greghunt commented Apr 3, 2024

I have a vite config that looks like this:

export default {
	root: 'client',
	plugins: [
		v4wp( {
			input: {
				settings: '/Page/Admin/Settings.tsx',
			},
			outDir: 'build',
		} ),
		react(),
	]
};

When running npm run build, it would respect the root client path and output the build directory in the client directory. But when running npm run dev the dev server doesn't account for the client root and outputs the build at the same level of the client directory.

Copy link
Owner

@kucrut kucrut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @greghunt!

Just a minor change needed.

src/exports/plugins/dev-server.js Outdated Show resolved Hide resolved
@kucrut
Copy link
Owner

kucrut commented Jul 29, 2024

Thanks for the PR update @greghunt. Feel free to add a changeset by running pnpm changeset; select patch and add a message. Please do add your GH username as props in the changeset message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants