Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tracetest): fix provisioning importing in configmap #935

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

schoren
Copy link
Contributor

@schoren schoren commented Sep 9, 2024

Pull request description

This PR fixes a bug on the chart causing provisioning to not work. It was failing with this message:

2024/09/09 16:17:45 [provisioning] attempting file:  /app/config/provisioning.yaml
2024/09/09 16:17:45 [provisioning] error: cannot unmarshal yaml for provisioning file: [1:1] scalar was used where mapping is expected
    >  1 | |
           ^

The issue was caused by an incorrect usage of a value in the configmap template, causing the provisioning file to look like this:

apiVersion: v1
data:
  config.yaml: |-
    # ...
  provisioning.yaml: |-
    | # this line here was the issue
      ---
      type: DataStore
      spec:
        name: Jaeger
        # Indicates that this datastore is a jaeger instance
        type: jaeger
        # Configures how tracetest connects to jaeger.
        jaeger:
          endpoint: jaeger-query:16685
          tls:
            insecure: true
      ---
      type: PollingProfile
      spec:
        name: Custom Profile
        strategy: periodic
        default: true
        periodic:
          timeout: 30s
          retryDelay: 500ms

An extra | pipe character prependend to the file was causing the provisioner to fail to parse the file, since it's invalid yaml.

This PR fixes the configmap template.

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

Breaking changes

Changes

Fixes

@schoren schoren requested a review from a team as a code owner September 9, 2024 16:37
@schoren schoren merged commit 1b87727 into main Sep 9, 2024
2 checks passed
@schoren schoren deleted the tracetest-fix-provisioning branch September 9, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants