Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin cfg, configure deps #8

Merged
merged 3 commits into from
Feb 26, 2024
Merged

Update plugin cfg, configure deps #8

merged 3 commits into from
Feb 26, 2024

Conversation

mszostok
Copy link
Collaborator

@mszostok mszostok commented Feb 25, 2024

Description

Changes proposed in this pull request:

  • update plugin configuration
  • configure plugin deps and use plugin.RunCommand helper.
  • use plugin kubeconfig

Testing

Setup demo:

Screen.Recording.2024-02-26.at.10.24.41.mov

FYI: I fixed the Brain schema here already: 0a9012d it was not deployed to the latest plugins so that's the reason why you will still see outdated one on app-dev 👍

Related issue(s)

@mszostok mszostok added the enhancement New feature or request label Feb 25, 2024
@mszostok mszostok requested review from a team and madebyrogal February 25, 2024 21:19
@mszostok mszostok marked this pull request as draft February 25, 2024 21:20
@mszostok mszostok marked this pull request as ready for review February 25, 2024 22:08
Copy link
Contributor

@madebyrogal madebyrogal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works very well!
Great refactoring!
Just one question in the comment

internal/source/ai-brain/config.go Show resolved Hide resolved
@mszostok mszostok merged commit c114f42 into main Feb 26, 2024
4 checks passed
@mszostok mszostok deleted the ai-follow-ups branch February 26, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants