ai-brain: thread mapping cache and better formatting of messages #11
Conversation
vaijab
force-pushed
the
aibrainiterate
branch
from
7b20181
to
1efe992
Compare
| return false, fmt.Errorf("got unexpected status: %s", run.Status) | ||
|
|
||
| case openai.RunStatusExpired: | ||
| i.cache.Delete(p.MessageID) |
There was a problem hiding this comment.
it would be good to send some user facing message:
i.out <- source.Event{
Message: msgExipredAIAnswer(p.MessageID),
}There was a problem hiding this comment.
Um, I was thinking about that, but an expired thread is by definition old, like 10 or more minutes old, so it could mean that response will be out of the blue and confusing. How about this, I'll make sure we'll add run status as an attribute to honeycomb and then we can see how often it happens, if at all.
There was a problem hiding this comment.
so side topic, should we even consider polling such runs? maybe we should change the input ctx?
and have sth like:
ctx, cancel := context.WithTimeout(ctx, 5*time.Minute)
so polling will be canceled after 5min (we can then also call CancelRun) and we can respond to the user that we were not able to process this prompt. Otherwise, user will see only:
internal/source/ai-brain/response.go
Outdated
| return text | ||
| } | ||
|
|
||
| // func markdownToTeams(markdownText string) string { |
There was a problem hiding this comment.
FYI: I didn't test that one; I can't tell if the replacement makes sense from the Teams platform perspective
vaijab
force-pushed
the
aibrainiterate
branch
3 times, most recently
from
36c53a4
to
52e3a21
Compare
vaijab
force-pushed
the
aibrainiterate
branch
from
52e3a21
to
7d305de
Compare
This is the next iteration in our journey to build a smarter botkube bot. I've added an internal cache to map messaging platform message id (think thread) to an OpenAI thread. The bot will be able to keep conversational context, which drastically improves UX.
I also added a hacky way of converting markdown markup text to slack compatible text markup. Need to somehow distinguish between slack and teams messages. I believe @mszostok has an idea.
Description
Changes proposed in this pull request:
Here is what it looks like, see screenshots below:
Better formatting
Related issue(s)
Related https://github.com/kubeshop/botkube-cloud/issues/843