Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sig-scalability/watchlist: increase the worker node instance type #29541

Merged
merged 1 commit into from
May 18, 2023
Merged

sig-scalability/watchlist: increase the worker node instance type #29541

merged 1 commit into from
May 18, 2023

Conversation

p0lyn0mial
Copy link
Contributor

@p0lyn0mial p0lyn0mial commented May 18, 2023 •
edited
Loading

The latest run for the watch-list-off test shows that the test binary (a job) wasn't scheduled because there were no nodes with sufficient resources (CPU) to run the job.

I'm proposing to increase the worker node type to e2-standard-16

xref: kubernetes/enhancements#3157
xref: #29531

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 18, 2023
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 18, 2023
@p0lyn0mial
Copy link
Contributor Author

/assing @mborsz @Argh4k

@Argh4k
Copy link
Contributor

Argh4k commented May 18, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 18, 2023
@p0lyn0mial
Copy link
Contributor Author

@mborsz please approve this PR and trigger https://prow.k8s.io/?job=ci-kubernetes-e2e-gci-gce-scalability-watch-list-on and https://prow.k8s.io/?job=ci-kubernetes-e2e-gci-gce-scalability-watch-list-off. Thanks!

@mborsz
Copy link
Member

mborsz commented May 18, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mborsz, p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2023
@k8s-ci-robot k8s-ci-robot merged commit e849828 into kubernetes:master May 18, 2023
@k8s-ci-robot
Copy link
Contributor

@p0lyn0mial: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-scalability-experimental-periodic-jobs.yaml using file config/jobs/kubernetes/sig-scalability/sig-scalability-experimental-periodic-jobs.yaml

In response to this:

The latest run for the watch-list-off test shows that the test binary (a job) wasn't scheduled because there were no nodes with sufficient resources (CPU) to run the job.

I'm proposing to increase the worker node type to e2-standard-16

xref: kubernetes/enhancements#3157
xref: #29531

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@p0lyn0mial
Copy link
Contributor Author

@mborsz @Argh4k can one of you give me instructions on how to add the new tests watch-list-off/watch-list-on to the perf-dashboard ?

@mborsz
Copy link
Member

mborsz commented May 18, 2023

Triggered https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-kubernetes-e2e-gci-gce-scalability-watch-list-on/1659109710302810112 and https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-kubernetes-e2e-gci-gce-scalability-watch-list-off/1659109727746920448

@mborsz
Copy link
Member

mborsz commented May 18, 2023

I suspect tags perfDashPrefix should do the job, but maybe something else needs to be done? @Argh4k do you know maybe?

@p0lyn0mial
Copy link
Contributor Author

Is the perfDashJobType correct ? shouldn't it be performance ?

    - "perfDashPrefix: watch-list-on"
    - "perfDashJobType: watchlist-on"

@p0lyn0mial
Copy link
Contributor Author

p0lyn0mial commented May 18, 2023 •
edited
Loading

Is the perfDashJobType correct ? shouldn't it be performance ?

   - "perfDashPrefix: watch-list-on"
  - "perfDashJobType: watchlist-on"

PTAL #29542

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marseel marseel Awaiting requested review from marseel

@mm4tt mm4tt Awaiting requested review from mm4tt

Assignees

@Argh4k Argh4k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@p0lyn0mial @Argh4k @mborsz @k8s-ci-robot