Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate Netlify deployment after default branch change #1034

Closed
wants to merge 1 commit into from
Closed

Validate Netlify deployment after default branch change #1034

wants to merge 1 commit into from

Conversation

tobiasgiese
Copy link
Member

@tobiasgiese tobiasgiese commented Nov 1, 2021 •
edited
Loading

The current Netlify deployment is the latest master commit. After this PR has been merged our Book will be updated also.

part of #855
xref: kubernetes/org#2883 (comment)

@netlify
Copy link

netlify bot commented Nov 1, 2021 •
edited
Loading

✔️ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

🔨 Explore the source changes: 6ce0626

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/61802240fd21db000705f7d1

😎 Browse the preview: https://deploy-preview-1034--kubernetes-sigs-cluster-api-openstack.netlify.app

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 1, 2021
@tobiasgiese
Copy link
Member Author

The current Netlify deployment is the latest master commit. After this PR has been merged our Book will be updated also.

@tobiasgiese
Copy link
Member Author

/cc @jichenjc @hidekazuna @sbueringer

@hidekazuna
Copy link
Contributor

@tobiasgiese Is this PR test purpose only? Or need to be merged?

@jichenjc
Copy link
Contributor

jichenjc commented Nov 2, 2021

I see tabs added but no additional code chnages, so same questions here..

@tobiasgiese
Copy link
Member Author

tobiasgiese commented Nov 2, 2021 •
edited
Loading

The current Netlify deployment is the latest master commit. After this PR has been merged our Book will be updated also.

See this description comment. We need a new commit on main to redeploy our book.
We can either wait for another PR or this one to be merged.

Edit: I moved the comment to the PR description

@jichenjc
Copy link
Contributor

jichenjc commented Nov 2, 2021

/lgtm

ok, I am ok to trigger this new book update ,no harm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2021
@tobiasgiese
Copy link
Member Author

/lgtm

ok, I am ok to trigger this new book update ,no harm

Thanks 🙂 could you add the approve label as well? Reviewer and org member do not have the approve permission

@jichenjc
Copy link
Contributor

jichenjc commented Nov 2, 2021

/approve

@jichenjc
Copy link
Contributor

jichenjc commented Nov 2, 2021

thanks for raising this up :)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc, tobiasgiese

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2021
@tobiasgiese
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 2, 2021
@tobiasgiese
Copy link
Member Author

The book was already updated by #1032 🥳

@tobiasgiese tobiasgiese closed this Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischdi chrischdi Awaiting requested review from chrischdi

@hidekazuna hidekazuna Awaiting requested review from hidekazuna

@jichenjc jichenjc Awaiting requested review from jichenjc

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

@jichenjc jichenjc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tobiasgiese @hidekazuna @jichenjc @k8s-ci-robot