Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update microsoft-entra-id-oidc-integration-for-kubecost.md #1155

Merged
merged 5 commits into from
Nov 27, 2024

Conversation

ivankube
Copy link
Contributor

@ivankube ivankube commented Nov 26, 2024

  1. Improve clientSecret line
  2. Add a note for Optional Claims.

Related Issue

SUP-6444

1.  Improve clientSecret line
2. Add a note for Optional Claims.
@ivankube ivankube requested a review from a team as a code owner November 26, 2024 18:15
Add Option 4 to Troubleshooting Section
ivankube and others added 2 commits November 27, 2024 14:01
…idc/microsoft-entra-id-oidc-integration-for-kubecost.md


improve the instructions

Co-authored-by: Thomas Nguyen <[email protected]>
…idc/microsoft-entra-id-oidc-integration-for-kubecost.md


remove unnecessary sentence

Co-authored-by: Thomas Nguyen <[email protected]>
Copy link
Member

@thomasvn thomasvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ivankube! Keep 'em coming!

@thomasvn thomasvn merged commit ca60bc8 into main Nov 27, 2024
5 checks passed
@thomasvn thomasvn deleted the ivankube-patch-2 branch November 27, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants