Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kuring-38 [수정] 서버에서 학과 이름이 바뀌었을 때 로컬 DB에도 반영하도록 수정 #65

Merged
merged 12 commits into from
Aug 21, 2023
Merged

kuring-38 [수정] 서버에서 학과 이름이 바뀌었을 때 로컬 DB에도 반영하도록 수정 #65

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
cd03251
kuring-38 [추가] 학과 이름을 업데이트하는 Dao 함수 추가
mwy3055 Jul 24, 2023
c7cc85a
kuring-38 [추가] DB에 저장된 학과 수를 반환하는 Dao 함수 추가
mwy3055 Jul 24, 2023
609c0eb
kuring-38 [수정] 학과 데이터가 이미 있을 땐 DB를 업데이트하도록 수정
mwy3055 Jul 24, 2023
92d8bdb
kuring-38 [추가] DepartmentDao 학과 업데이트 테스트 작성
mwy3055 Jul 24, 2023
974cf8d
kuring-38 [수정] 로컬 DB 코드를 테스트 루트 패키지로 이동
mwy3055 Jul 24, 2023
609da58
kuring-38 [수정] Repository 함수 이름을 기능에 맞게 변경
mwy3055 Jul 24, 2023
27943b1
kuring-38 [추가] DepartmentRepository 학과 업데이트 테스트 코드 작성
mwy3055 Jul 24, 2023
612c6be
kuring-38 [수정] shortName 또는 koreanName이 바뀐 학과만 업데이트하도록 개선
mwy3055 Jul 24, 2023
7229fa0
kuring-38 [수정] 테스트 코드를 깔끔하게 수정
mwy3055 Jul 24, 2023
5a414dc
kuring-62 [수정] 학과 업데이트 함수를 보완
mwy3055 Aug 20, 2023
65104b6
kuring-62 [수정] 테이블이 비어 있는지 확인하는 쿼리 최적화
mwy3055 Aug 20, 2023
d0bec15
kuring-62 [수정] 외부에서 사용하지 않는 함수를 Repository 정의에서 제거
mwy3055 Aug 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions app/src/main/java/com/ku_stacks/ku_ring/repository/DepartmentRepositoryImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,10 @@ class DepartmentRepositoryImpl @Inject constructor(
}

private suspend fun updateDepartmentsName(departments: List<Department>) {
val sortedOriginalDepartments = this.departments?.sortedBy { it.name }
val sortedOriginalDepartments = getAllDepartments().sortedBy { it.name }
val updateTargets = departments.filter { department ->
val originalPosition =
sortedOriginalDepartments?.binarySearch { it.name.compareTo(department.name) }
?: return@filter true
sortedOriginalDepartments.binarySearch { it.name.compareTo(department.name) }
yeon-kyu marked this conversation as resolved.
Show resolved Hide resolved
val originalDepartment = sortedOriginalDepartments[originalPosition]
return@filter originalDepartment.name != department.name || originalDepartment.koreanName != department.koreanName
yeon-kyu marked this conversation as resolved.
Show resolved Hide resolved
}
Expand Down