Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kuring-38 [수정] 서버에서 학과 이름이 바뀌었을 때 로컬 DB에도 반영하도록 수정 #65

Merged
merged 12 commits into from
Aug 21, 2023
Merged

kuring-38 [수정] 서버에서 학과 이름이 바뀌었을 때 로컬 DB에도 반영하도록 수정 #65

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
cd03251
kuring-38 [추가] 학과 이름을 업데이트하는 Dao 함수 추가
mwy3055 Jul 24, 2023
c7cc85a
kuring-38 [추가] DB에 저장된 학과 수를 반환하는 Dao 함수 추가
mwy3055 Jul 24, 2023
609c0eb
kuring-38 [수정] 학과 데이터가 이미 있을 땐 DB를 업데이트하도록 수정
mwy3055 Jul 24, 2023
92d8bdb
kuring-38 [추가] DepartmentDao 학과 업데이트 테스트 작성
mwy3055 Jul 24, 2023
974cf8d
kuring-38 [수정] 로컬 DB 코드를 테스트 루트 패키지로 이동
mwy3055 Jul 24, 2023
609da58
kuring-38 [수정] Repository 함수 이름을 기능에 맞게 변경
mwy3055 Jul 24, 2023
27943b1
kuring-38 [추가] DepartmentRepository 학과 업데이트 테스트 코드 작성
mwy3055 Jul 24, 2023
612c6be
kuring-38 [수정] shortName 또는 koreanName이 바뀐 학과만 업데이트하도록 개선
mwy3055 Jul 24, 2023
7229fa0
kuring-38 [수정] 테스트 코드를 깔끔하게 수정
mwy3055 Jul 24, 2023
5a414dc
kuring-62 [수정] 학과 업데이트 함수를 보완
mwy3055 Aug 20, 2023
65104b6
kuring-62 [수정] 테이블이 비어 있는지 확인하는 쿼리 최적화
mwy3055 Aug 20, 2023
d0bec15
kuring-62 [수정] 외부에서 사용하지 않는 함수를 Repository 정의에서 제거
mwy3055 Aug 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions app/src/main/java/com/ku_stacks/ku_ring/data/db/DepartmentDao.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,12 @@ interface DepartmentDao {
@Query("SELECT * FROM departments WHERE koreanName LIKE '%' || :koreanName || '%'")
suspend fun getDepartmentsByKoreanName(koreanName: String): List<DepartmentEntity>

@Query("SELECT COUNT(*) FROM departments")
suspend fun getDepartmentsSize(): Int
yeon-kyu marked this conversation as resolved.
Show resolved Hide resolved

@Query("UPDATE departments SET shortName = :shortName, koreanName = :koreanName WHERE name = :name")
suspend fun updateDepartment(name: String, shortName: String, koreanName: String)

@Query("SELECT * FROM departments WHERE isSubscribed = :isSubscribed")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DB에 관심이 많아 한가지 댓글 남겨봅니다!
SELECT 문에서 *는 지양하는 것 이 좋습니다!! 여러 이유가 있지만 다음 글이 잘 설명해주는 것 같아 링크 남겨봅니다
관련 링크 : https://hyewoncc.github.io/sql-no-wildcard/

Copy link
Member

@yeon-kyu yeon-kyu Aug 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

select *를 지양하는 이유가 7가지나 있군요! Entity를 가져와서 비즈니스로직을 처리하는곳에서는 어쩔수없이 select * 를 사용해야겠지만(꽤 많은경우가 이렇긴할것같아요 ㅠ) 단순한 로직에선 지양하는게 좋을것 같네요
정보공유 감사합니다~!

suspend fun getDepartmentsBySubscribed(isSubscribed: Boolean): List<DepartmentEntity>

Expand Down
15 changes: 14 additions & 1 deletion app/src/main/java/com/ku_stacks/ku_ring/repository/DepartmentRepositoryImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,11 @@ class DepartmentRepositoryImpl @Inject constructor(
override suspend fun insertAllDepartmentsFromRemote() {
val departments = fetchAllDepartmentsFromRemote()
departments?.let {
departmentDao.insertDepartments(departments.map { it.toEntity() })
if (departmentDao.getDepartmentsSize() == 0) {
departmentDao.insertDepartments(departments.toEntityList())
} else {
updateDepartmentsName(it)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

학과 DB가 비어 있다면 서버에서 가져온 데이터를 그대로 삽입하고, 비어 있지 않다면 서버에서 가져온 데이터와 비교하여 DB를 업데이트합니다.

}
}
}

Expand All @@ -36,6 +40,15 @@ class DepartmentRepositoryImpl @Inject constructor(
}.getOrNull()
}

private suspend fun updateDepartmentsName(departments: List<Department>) {
withContext(ioDispatcher) {
departments.forEach { (name, shortName, koreanName, _) ->
departmentDao.updateDepartment(name, shortName, koreanName)
}
}
this.departments = null
yeon-kyu marked this conversation as resolved.
Show resolved Hide resolved
}

override suspend fun insertDepartment(department: Department) {
withContext(ioDispatcher) {
departmentDao.insertDepartment(department.toEntity())
Expand Down