Don't include window and group in Query. #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomprince
force-pushed
the
no-window-in-query
branch
2 times, most recently
from
51707a8
to
d4eae91
Compare
|
Ping. |
|
Why not use |
tomprince
force-pushed
the
no-window-in-query
branch
from
d4eae91
to
bdd27a1
Compare
|
That would probably make sense. I was just factoring out the existing parameters into separate ones. I also only have mpd 0.19 here, which doesn't have support for windowing, so I'm not able to test it. My inclination would be to leave it as is, and then incrementally improve it later. |
|
Added #19 as a reminder for enhancement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11.
I'm not sure if the window stuff works; I don't have mpd 0.20 here.
I wonder if there is some clever way to handle the version differences and only expose supported options?