Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure hatch is installed with the correct Python version in CI #462

Merged
merged 5 commits into from
Aug 1, 2024

Conversation

jacobtomlinson
Copy link
Member

@jacobtomlinson jacobtomlinson commented Aug 1, 2024

Closes #461
Contributes towards #459

Using pipx to install hatch was causing the system python to be used in pytest. Switching to standard pip resolves this.

Also fix up some Python 3.8 type annotation things that were previously missed by CI.

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.10%. Comparing base (87063fc) to head (f92b8b3).
Report is 128 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #462      +/-   ##
==========================================
+ Coverage   94.61%   95.10%   +0.48%     
==========================================
  Files          29       30       +1     
  Lines        3141     3884     +743     
==========================================
+ Hits         2972     3694     +722     
- Misses        169      190      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the kr8s label Aug 1, 2024
@jacobtomlinson jacobtomlinson marked this pull request as ready for review August 1, 2024 10:14
@jacobtomlinson jacobtomlinson changed the title Try to ensure hatch is installed with the correct Python version Ensure hatch is installed with the correct Python version Aug 1, 2024
@jacobtomlinson jacobtomlinson changed the title Ensure hatch is installed with the correct Python version Ensure hatch is installed with the correct Python version in CI Aug 1, 2024
@jacobtomlinson jacobtomlinson added the bug Something isn't working label Aug 1, 2024
@jacobtomlinson jacobtomlinson merged commit 04ef5e9 into kr8s-org:main Aug 1, 2024
11 checks passed
@jacobtomlinson jacobtomlinson deleted the ci-hatch branch August 1, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci kr8s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python versions in CI are being incorrectly tested
1 participant