Start getting mypy --strict
passing
#429
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking first steps towards #428.
I started this PR by adding some type annotations to tests before deciding to just exclude tests, but I don't see ay harm in leaving those changes in.
I think the only thing we really care about is having good type annotations on the
kr8s
module itself, so I've excluded all other Python code frommypy
linting.Other typing fixes here include using
__all__
to explicitly re-export things at thekr8s
andkr8s.asyncio
levels and adding annotations to the exceptions submodule.After this PR there are
237
errors when runningmypy --strict .
.