Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completed Chapter 1 and Chapter 2 #546

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Completed Chapter 1 and Chapter 2 #546

wants to merge 16 commits into from

Conversation

jedau
Copy link

@jedau jedau commented Oct 17, 2022

Solutions for Chapter 1 and Chapter 2

Summoning @vrom911 and @chshersh for review! Any feedback is greatly appreciated 😄

PS This was such a fun tutorial. Kudos to you folks! Will definitely be coming back to finish the remaining chapters. I've been looking for an engaging Haskell tutorial for a while now and I can't believe I stumbled upon one while participating in Hacktoberfest!

PPS I realized that I made so many commits for my Chapter 1 PR, so I squashed them to just 1 for Chapter 2 😅 Hoping I can get an approval for these as I'm trying to complete my first Hacktoberfest. Thanks!

@jedau jedau requested a review from vrom911 as a code owner October 17, 2022 14:53
@jedau jedau changed the title Completed Chapter 1 Completed Chapter 1 and Chapter 2 Oct 22, 2022
@jedau
Copy link
Author

jedau commented Oct 22, 2022

@vrom911 I'm not sure why the Doctest is failing for Chapter 2. Initially, it expected "some string" :: [Char] so I changed it to "some string" :: [Char] from "some string" :: String, but now it's expecting String as the data type. Very confused how to resolve this issue. Any assistance would be appreciated 😄

@vrom911 vrom911 added chapter1 hacktoberfest-accepted https://hacktoberfest.digitalocean.com/ chapter2 labels Oct 27, 2022
This was referenced Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chapter1 chapter2 hacktoberfest-accepted https://hacktoberfest.digitalocean.com/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants