Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make team page reactive #79

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

BAGUVIX456
Copy link

Fixes issue #61

Ignore the terribly written code :)

Copy link

vercel bot commented Sep 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
yakw ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 6:10am

Copy link
Member

@harshkhandeparkar harshkhandeparkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions. Code is fine btw :)

package.json Outdated Show resolved Hide resolved
src/components/TeamTab.astro Outdated Show resolved Hide resolved
src/components/TeamTab.astro Outdated Show resolved Hide resolved
@rohan-b-84
Copy link

This warning still exists when I try to run it...
Can you look into this @BAGUVIX456 ?

Invalid hook call. Hooks can only be called inside of the body of a function component. This could happen for one of the following reasons:
1. You might have mismatching versions of React and the renderer (such as React DOM)
2. You might be breaking the Rules of Hooks
3. You might have more than one copy of React in the same app
See https://react.dev/link/invalid-hook-call for tips about how to debug and fix this problem.
Each child in a list should have a unique "key" prop.

Check the top-level render call using <div>. See https://react.dev/link/warning-keys for more information.
    at a
    at Tester
Invalid DOM property `class`. Did you mean `className`?
    at div
    at TeamTab (/media/work/KOSS/YAKW/src/components/TeamTab.tsx:17:97)
Invalid hook call. Hooks can only be called inside of the body of a function component. This could happen for one of the following reasons:
1. You might have mismatching versions of React and the renderer (such as React DOM)
2. You might be breaking the Rules of Hooks
3. You might have more than one copy of React in the same app
See https://react.dev/link/invalid-hook-call for tips about how to debug and fix this problem.

@BAGUVIX456
Copy link
Author

BAGUVIX456 commented Oct 7, 2024

@rohan-b-84 I could not trace the cause of the 'invalid hook call' warning. Checked dependency versions too and they seemed all right

Copy link
Member

@harshkhandeparkar harshkhandeparkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i trust whoever will approve after me. please merge it once approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants