Skip to content

Commit

Permalink
suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Andrew Lamb <[email protected]>
  • Loading branch information
korowa and alamb authored Dec 16, 2023
1 parent ac77d77 commit c94f169
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions datafusion/physical-plan/src/joins/hash_join.rs
Original file line number Diff line number Diff line change
Expand Up @@ -815,7 +815,7 @@ struct BuildSideReadyState {
impl BuildSide {
/// Tries to extract BuildSideInitialState from BuildSide enum.
/// Returns an error if state is not Initial.
fn try_into_initial_mut(&mut self) -> Result<&mut BuildSideInitialState> {
fn try_as_initial_mut(&mut self) -> Result<&mut BuildSideInitialState> {
match self {
BuildSide::Initial(state) => Ok(state),
_ => Err(DataFusionError::Internal(
Expand All @@ -826,7 +826,7 @@ impl BuildSide {

/// Tries to extract BuildSideReadyState from BuildSide enum.
/// Returns an error if state is not Ready.
fn try_into_ready(&self) -> Result<&BuildSideReadyState> {
fn try_as_ready(&self) -> Result<&BuildSideReadyState> {
match self {
BuildSide::Ready(state) => Ok(state),
_ => Err(DataFusionError::Internal(
Expand All @@ -837,7 +837,7 @@ impl BuildSide {

/// Tries to extract BuildSideReadyState from BuildSide enum.
/// Returns an error if state is not Ready.
fn try_into_ready_mut(&mut self) -> Result<&mut BuildSideReadyState> {
fn try_as_ready_mut(&mut self) -> Result<&mut BuildSideReadyState> {
match self {
BuildSide::Ready(state) => Ok(state),
_ => Err(DataFusionError::Internal(
Expand Down

0 comments on commit c94f169

Please sign in to comment.