Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Propagate dep labels. #62

Merged
merged 2 commits into from
Nov 15, 2023
Merged

🐛 Propagate dep labels. #62

merged 2 commits into from
Nov 15, 2023

Conversation

jortel
Copy link
Contributor

@jortel jortel commented Nov 14, 2023

Propagate dep provider and labels.

Signed-off-by: Jeff Ortel <[email protected]>
Copy link
Contributor

@shawn-hurley shawn-hurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Do we have to have an associated test update?

builder/deps.go Show resolved Hide resolved
Signed-off-by: Jeff Ortel <[email protected]>
@jortel
Copy link
Contributor Author

jortel commented Nov 15, 2023

LGTM

Do we have to have an associated test update?

This would be an integration test which don't live in this project.

@shawn-hurley
Copy link
Contributor

I agree, but shouldn't we have a test PR to the test repo and to test them together?

@jortel
Copy link
Contributor Author

jortel commented Nov 15, 2023

I agree, but shouldn't we have a test PR to the test repo and to test them together?

Ah. Yes we should. Any idea how to test them together?

@jortel
Copy link
Contributor Author

jortel commented Nov 15, 2023

Test PR: konveyor/go-konveyor-tests#63

@jortel jortel merged commit 9b98157 into konveyor:main Nov 15, 2023
6 checks passed
ibolton336 added a commit to konveyor/tackle2-ui that referenced this pull request Nov 15, 2023
- Add management column for application dependencies table
- Add parsed label conversion for dependency labels
#1339

Depends on konveyor/tackle2-addon-analyzer#62

Signed-off-by: ibolton336 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants