Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR][CR] adapted to submit button and fixed field_validation #713

Merged
merged 5 commits into from
Sep 11, 2023
Merged

[RFR][CR] adapted to submit button and fixed field_validation #713

merged 5 commits into from
Sep 11, 2023
+13 −12

Conversation

Neilhamza
Copy link
Collaborator

@Neilhamza Neilhamza commented Sep 10, 2023 •
edited
Loading

ibragins
ibragins requested changes Sep 10, 2023
View reviewed changes
Copy link
Collaborator

@ibragins ibragins left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as I told you, you can use submitForm(); function when you need to just submit form. Please use it where possible.

@Neilhamza
using submitForm method
65ff648 
Signed-off-by: Neilhamza <[email protected]>
@Neilhamza Neilhamza changed the title [RFR] adapted to submit button [RFR] adapted to submit button and fixed field_validation Sep 11, 2023
sshveta
sshveta approved these changes Sep 11, 2023
View reviewed changes
Copy link
Collaborator

@sshveta sshveta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to see that we are able to use selectors from common views everywhere.

@sshveta sshveta merged commit 5a8f49e into konveyor:main Sep 11, 2023
3 of 4 checks passed
@sshveta sshveta changed the title [RFR] adapted to submit button and fixed field_validation [RFR][CR] adapted to submit button and fixed field_validation Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibragins ibragins ibragins requested changes

@abrugaro abrugaro abrugaro approved these changes

@sshveta sshveta sshveta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Neilhamza @sshveta @ibragins @abrugaro