Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR][TA] Custom metrics after bulk analysis #708

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

kpunwatk
Copy link
Collaborator

@kpunwatk kpunwatk commented Sep 5, 2023

Signed-off-by: Karishma Punwatkar [email protected]

modified:   cypress/e2e/tests/migration/applicationinventory/analysis/bulk_analysis.test.ts

@kpunwatk
Copy link
Collaborator Author

kpunwatk commented Sep 5, 2023

The TC automated MTA-356 [Custom Metrics] Count the total number of initiated tasks after a bulk analysis

@kpunwatk kpunwatk changed the title [WIP] Custom metrics after bulk analyses [RFR][TA] Custom metrics after bulk analyses Sep 5, 2023
@kpunwatk kpunwatk changed the title [RFR][TA] Custom metrics after bulk analyses [RFR][TA] Custom metrics after bulk analysis Sep 5, 2023
@abrugaro
Copy link
Collaborator

abrugaro commented Sep 5, 2023

Can you rename the file with somethin more specific to what the test does, like bulk_analaysis_with_custom_metrics, to emphatize that this is also the only suite that tests the bulk analysis?

@sshveta
Copy link
Collaborator

sshveta commented Sep 5, 2023

Can you rename the file with somethin more specific to what the test does, like bulk_analaysis_with_custom_metrics, to emphatize that this is also the only suite that tests the bulk analysis?

Yeah rename it to "Test bulk analysis and collect custom metrics afterwards "

@kpunwatk kpunwatk force-pushed the custom_bulkAnalyis branch 2 times, most recently from 00e43d9 to 68f0756 Compare September 5, 2023 17:35
@kpunwatk
Copy link
Collaborator Author

kpunwatk commented Sep 5, 2023

Can you rename the file with somethin more specific to what the test does, like bulk_analaysis_with_custom_metrics, to emphatize that this is also the only suite that tests the bulk analysis?

Yeah rename it to "Test bulk analysis and collect custom metrics afterwards "

Done Renamed the file, Thanks !

Copy link
Collaborator

@abrugaro abrugaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@mguetta1 mguetta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the test file's name start with uppercase letter?
Other than that, looks good to me

@sshveta
Copy link
Collaborator

sshveta commented Sep 5, 2023

Can you rename the file with somethin more specific to what the test does, like bulk_analaysis_with_custom_metrics, to emphatize that this is also the only suite that tests the bulk analysis?

Yeah rename it to "Test bulk analysis and collect custom metrics afterwards "

I think I confused you , This will be the TC name .
Test file name can stay as bulk_analysis.test.ts

Signed-off-by: Karishma Punwatkar <[email protected]>
@sshveta sshveta merged commit 1d5abb7 into konveyor:main Sep 6, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants