-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFR][TA] Custom metrics after bulk analysis #708
Conversation
The TC automated MTA-356 [Custom Metrics] Count the total number of initiated tasks after a bulk analysis |
cded685
to
12f804c
Compare
...e2e/tests/migration/applicationinventory/analysis/custom_metrics_after_bulk_analysis.test.ts
Outdated
Show resolved
Hide resolved
...e2e/tests/migration/applicationinventory/analysis/custom_metrics_after_bulk_analysis.test.ts
Outdated
Show resolved
Hide resolved
12f804c
to
f38056c
Compare
Can you rename the file with somethin more specific to what the test does, like |
Yeah rename it to "Test bulk analysis and collect custom metrics afterwards " |
00e43d9
to
68f0756
Compare
Done Renamed the file, Thanks ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
68f0756
to
74c4797
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the test file's name start with uppercase letter?
Other than that, looks good to me
I think I confused you , This will be the TC name . |
74c4797
to
5a34568
Compare
Signed-off-by: Karishma Punwatkar <[email protected]>
5a34568
to
3fb9b30
Compare
Signed-off-by: Karishma Punwatkar [email protected]