[RFR] [TA] Add test for importing .csv file with missing application name #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nandini Chandra <[email protected]>
Signed-off-by: Nandini Chandra <[email protected]>
nachandr
changed the title
Signed-off-by: Nandini Chandra <[email protected]>
nachandr
force-pushed
the
import_csv_without_app_name
branch
from
40bf900
to
e11ab03
Compare
Signed-off-by: Nandini Chandra <[email protected]>
abrugaro
requested changes
Sep 4, 2023
cypress/e2e/tests/migration/applicationinventory/assessment/import.test.ts
Outdated
Show resolved
Hide resolved
nachandr
force-pushed
the
import_csv_without_app_name
branch
from
5acc9fe
to
a52c058
Compare
Signed-off-by: Nandini Chandra <[email protected]>
nachandr
force-pushed
the
import_csv_without_app_name
branch
from
a52c058
to
0a857c8
Compare
|
Results : deleteApplicationTableRows() is failing in the after() hook. I'll investigate it and fix it it a follow up PR.
|
sshveta
requested changes
Sep 5, 2023
cypress/e2e/tests/migration/applicationinventory/assessment/import.test.ts
Outdated
Show resolved
Hide resolved
cypress/e2e/tests/migration/applicationinventory/assessment/import.test.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Nandini Chandra <[email protected]>
sshveta
approved these changes
Sep 6, 2023
abrugaro
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test for importing .csv file with missing application name