✨ Reflection fixes with Llama 70b #52
Conversation
Signed-off-by: Pranav Gaikwad <[email protected]>
| <version>7.0</version> | ||
| <groupId>jakarta.platform</groupId> | ||
| <artifactId>jakarta.jakartaee-api</artifactId> | ||
| <version>8.0.0</version> |
There was a problem hiding this comment.
Note to ourselves, I want to update the dependency agent to actuall not give the version here.
The version should come from the POM because the Quarkus BOM is actually like a platform in that it has all the dependent versions that should be used with a specific version of Quarkus.
|
|
||
| import com.redhat.coolstore.model.Product; | ||
| import com.redhat.coolstore.service.ProductService; | ||
|
|
||
| @RequestScoped | ||
| @Path("/products") | ||
| @Consumes(MediaType.APPLICATION_JSON) |
| import io.smallrye.reactive.messaging.jms.JmsPoolTypeImpl; | ||
| import io.smallrye.reactive.messaging.jms.JmsPoolTypeImpl; | ||
| import io.smallrye.reactive.messaging.jms.JmsPoolTypeImpl; |
| return BigDecimal.valueOf(value * percentOfTotal) | ||
| .setScale(2, RoundingMode.HALF_UP) | ||
| .doubleValue(); | ||
| return value * percentOfTotal; |
There was a problem hiding this comment.
I don't know if this is a valid change, a BigDecimal should probably still be used IIRC about dealing money things in Java
| import javax.jms.Topic; | ||
| import jakarta.enterprise.context.ApplicationScoped; | ||
| import jakarta.inject.Inject; | ||
| import io.smallrye.reactive.messaging.Channel; |
There was a problem hiding this comment.
I do notice that io.smallrye is not added to the pom, are you still getting mvn compile time errors?
There was a problem hiding this comment.
@shawn-hurley so there is an issue about maven parsing I am fixing now. The issue is that - we add a bad quarkus dip but we don't fix that because of parsing issues and then from that point onwards, we always get the same error in pom ignoring everything else.
| # This file should be renamed to application.properties |
There was a problem hiding this comment.
I filed konveyor/kai#502 to track being able to handle this rename/move of file
Compare this with #45 to see the difference.
Notice that there are no longer bad updates made (omitted code, functionality changes, among other minor things)