Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update prefetch-dependencies to 0.2 to support sub-paths #1605

Closed
wants to merge 1 commit into from

Conversation

ligangty
Copy link
Contributor

We're developing a new build pipeline to support build maven zip oci-artifacts, which needs cachi2 support to read multiple lockfiles of "generic" pkg type. This PR added that subpaths support.

@ligangty ligangty force-pushed the mrrc-build branch 8 times, most recently from 9071907 to 6f5cf7f Compare November 14, 2024 08:47
@chmeliik
Copy link
Contributor

@ligangty could you give the PR a more complete description? What is it for? What does cachi2 not support that you want it to support?

@ligangty
Copy link
Contributor Author

ligangty commented Nov 14, 2024

@chmeliik In our new pipeline, we will use the recent feature of cachi2 to download "generic" type of artifacts(for maven) from cachi2 specific lockfile (should be covered in here: containerbuildsystem/cachi2#692), and also need to specify multiple paths of lockfiles with json flag like:
cachi2 fetch-deps '{ "packages": [ {"type": "generic", "path": "path1"}, {"type": "generic", "path": "path2"} ] }'
Seems current prefetch task does not support this requirement, that's why I gave this PR. I'm not sure if I need to give this as "0.2" or just change it directly in "0.1". Please correct me if I'm in wrong way.

@chmeliik
Copy link
Contributor

chmeliik commented Nov 14, 2024

@chmeliik In our new pipeline, we will use the recent feature of cachi2 to download "generic" type of artifacts(for maven) from cachi2 specific lockfile (should be covered in here: containerbuildsystem/cachi2#692), and also need to specify multiple paths of lockfiles with json flag like: cachi2 fetch-deps '{ "packages": [ {"type": "generic", "path": "path1"}, {"type": "generic", "path": "path2"} ] }' Seems current prefetch task does not support this requirement, that's why I gave this PR. I'm not sure if I need to give this as "0.2" or just change it directly in "0.1". Please correct me if I'm in wrong way.

I think that should work fine in version 0.1 (without the changes in this PR) 🤔

@chmeliik
Copy link
Contributor

I think that should work fine in version 0.1 (without the changes in this PR) 🤔

Have you tried setting prefetch-input to { "packages": [ {"type": "generic", "path": "path1"}, {"type": "generic", "path": "path2"} ] }?

@ligangty
Copy link
Contributor Author

I think that should work fine in version 0.1 (without the changes in this PR) 🤔

Have you tried setting prefetch-input to { "packages": [ {"type": "generic", "path": "path1"}, {"type": "generic", "path": "path2"} ] }?

@chmeliik this is working! Thanks for the info. I'll close this one.

@ligangty ligangty closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants