secure enclave keys init follow up #1647
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
James-Pickett
changed the title
directionless
approved these changes
Mar 13, 2024
| @@ -105,16 +105,37 @@ func generateLauncherInfoTable(store types.GetterSetter) table.GenerateFunc { | |||
| if err != nil { | |||
| return nil, fmt.Errorf("marshalling hardware keys: %w", err) | |||
| } | |||
| results[0]["hardware_key"] = string(jsonBytes) | |||
There was a problem hiding this comment.
I think it's fine to drop this, but we'll need to update k2 to stop querying it
There was a problem hiding this comment.
I don't fully grok what needs to happen server side. We could just leave the name as hardware_key, but it feels weird since it will now be a json array. I reached out on slack
|
closed for #1658 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.