Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop operation and seek_iai benches #388

Merged
merged 4 commits into from
Oct 24, 2023
Merged

Drop operation and seek_iai benches #388

merged 4 commits into from
Oct 24, 2023

Commits on Oct 23, 2023

  1. Drop operations bench 

    The `operations` bench is no longer useful, yet pulls in polars, a
huge dependency. Back when we did not yet have a full reasoner
implemented, verifying correctness of our joins by comparing with the
polars implementation was useful. This is now covered by, among other
things, our end-to-end tests. Polars is not only a huge dependency
taking a lot of time to compile, but also breaks its API on minor
version bumps (which is not technically a semver violation, since it's
still 0.x, but requires changes to the bench code). Furthermore,
the bench uses internal Nemo APIs and thus also frequently requires
changes, which is often only discovered in CI, since the bench takes
much too long to run regularly. Lastly, it's not pratically useable
for external people, since it depends on test data that is not freely
redistributable.
    @mmarx
    mmarx committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    03e6d59 View commit details
    Browse the repository at this point in the history

  2. Drop seek_iai bench 

    `iai` is unmaintained and breaks with `valgrind-3.21`.
    @mmarx
    mmarx committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    e002cf7 View commit details
    Browse the repository at this point in the history

  3. flake.lock: Update 

    Flake lock file updates:

• Updated input 'nixpkgs':
    'github:NixOS/nixpkgs/898cb2064b6e98b8c5499f37e81adbdf2925f7c5' (2023-10-13)
  → 'github:NixOS/nixpkgs/5550a85a087c04ddcace7f892b0bdc9d8bb080c8' (2023-10-21)
• Updated input 'nixpkgs-unstable':
    'github:NixOS/nixpkgs/ca012a02bf8327be9e488546faecae5e05d7d749' (2023-10-16)
  → 'github:NixOS/nixpkgs/7c9cc5a6e5d38010801741ac830a3f8fd667a7a0' (2023-10-19)
• Updated input 'rust-overlay':
    'github:oxalica/rust-overlay/a2ccfb2134622b28668a274e403ba6f075ae1223' (2023-10-18)
  → 'github:oxalica/rust-overlay/a3e829c06eadf848f13d109c7648570ce37ebccd' (2023-10-22)
    @mmarx
    mmarx committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    0ae02a6 View commit details
    Browse the repository at this point in the history

  4. Satisfy clippy

    @mmarx
    mmarx committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    41676d9 View commit details
    Browse the repository at this point in the history