Raises an error if styleguide section comment misses section definition #109
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this patch, if one tried to access a section (name) of a parsed KSS section comment that misses the section name definition, a
NoMethodError: undefined method
[]' for nil:NilClass` was thrown because the code assumed the Regex for finding the section name always succeeded.To handle this error of a missing or wrongly formatted section name catching the very generic
NoMethodError
is not specific enough. I therefore introduced aSectionNotDefinedError
that can be catched instead.