UXUI3: Options, Find&Replace, 3D G-Code Viewer #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockstorm101
reviewed
Aug 7, 2023
|
Can't thank you enough for these contributions. Much appreciated. Out of curiosity, are you planning on more UX updates? If yes, awesome! keep them coming! If not, great as well, I think it is time for a new release then :) |
|
Great, thank you for reviewing it @rockstorm101 !
Yes I have plenty of points that I would like to address. Some are already in the making. I've got a few more updates to make to the dialogues, and then maybe we can draw the line for a new release in autumn. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
this is Pronterface ui tweaking part 3. It contains the following changes and enhancements:
Refactored get_space function. It is now much more elegant and does not rely on Python 3.10 features. Fixes Pronterface broken in Python 3.9 or older #1362
Macro Editor: 'Find and replace' dialogue is now complete with all options working
Options dialogue: some additional formatting, widgets now have homogeneous lengths
Options dialogue: Added new setting type for directories, for cases like 'Log path'. They now have a 'Browse' button which opens a 'Choose Directory...' dialogue
G-Code Viewer 3D view: An oversight on my part, sizer and toolbar work correctly now in 3D mode.
G-Code Viewer 3D view: The background colour of the 3D view is now the same as in the main window.
utils.py: just linting... I started to implement something here, but ended up not doing it and just keeping the cleanup changes.
As always, don't spare the feedback! :) And have a nice summer.