Fixed the crash on application launch under Windows #1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like the bug was not triggerred under Linux due to a different order of function calls (because of some peculiarity of concurrent execution and/or signal processing).
The bug itself happens due to initialization&update of MultiZimButton (via established signal/slot connections) at a time when the main application window hasn't yet been shown and the dimensions of various widgets are bogus. The end result is that a too narrow menu leads to the elided text string being empty which was outside of the assumptions of the getElidedText() function.
rgaudin
approved these changes
Nov 21, 2024
ShaopengLin
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
LGTM. The chopped change isn't a hack as it is indeed something we need to handle. Not sure why they would leave it as undefined behaviour tho...
Note: The behavior is undefined if len is negative or greater than size().
|
Please open the two issues, IMHO they are both blockerw for 2.5.0. |
@ShaopengLin That fix is a hack since its only purpose is to prevent a crash. It doesn't make any sense to elide text in such a way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1235
Other noticed issues (that should be fixed in separate PRs):