add KSM (Kusama) support #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeTamanoir
approved these changes
Jun 24, 2024
src/services/dot.ts
Outdated
| async decodeTx(txSerialized: string): Promise<UnsignedTransaction> { | ||
| const { data } = await api.get<UnsignedTransaction>(`/v1/dot/transaction/decode?tx_serialized=${txSerialized}`); | ||
| return data; | ||
| mainToPlanck(amount: string): string { |
There was a problem hiding this comment.
why name it "generically" if it does not do the same for KSM and DOT ?
There was a problem hiding this comment.
this function has the same role for all substrate tokens, converting from the main token to planck however the conversion rate is different for DOT, WND & KSM hence the abstract keyword. Does this not look straight forward to you?
There was a problem hiding this comment.
for all other protocols we have a naming with token names no ?
There was a problem hiding this comment.
for consistency I guess we should have ksmToPlanck and dotToPlanck no ?
There was a problem hiding this comment.
Ok let me find a workaround. Let me know if this looks good for you
goulinkh
force-pushed
the
add-ksm-support
branch
from
38ef7b7
to
3fd3984
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.