Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

커뮤니티 UI 개선 #149

Merged
merged 9 commits into from
May 26, 2024
Merged

커뮤니티 UI 개선 #149

merged 9 commits into from
May 26, 2024

Conversation

gwansikk
Copy link
Member

Summary

커뮤니티 UI를 개선합니다.

Tasks

  • 게시글 제목에 댓글을 추가했어요. 7f87cb0
  • 모아보기에 썸네일이 있을 경우 표시 되도록 수정했어요. 1f590e2
  • 게시글이 로딩 상태일 때 스켈레톤이 표시 되도록 추가했어요. b0b9002
  • 개발 환경을 경우 네비바의 하단 테두리 색을 주황색으로 표시하여 개발 환경인 것을 직관적이게 확인할 수 있도록 했어요. 28719cb
  • 카테고리 관련 함수를 최적화 했어요. 5f0f179

ETC

  • useBoards 훅을 useSuspenseInfiniteQuery(무한 스크롤 방식)으로 변경했어요. 5972c59

Screenshot

게시글 댓글 표시 모아보기 썸네일 게시글 스켈레톤
image image image

@gwansikk gwansikk added 🔨 Refactor 코드 수정 및 최적화 🏠 Member member 프로젝트 관련 labels May 26, 2024
@gwansikk gwansikk self-assigned this May 26, 2024
@gwansikk gwansikk linked an issue May 26, 2024 that may be closed by this pull request
[Member] 커뮤니티 게시글 댓글 표시 #147
Closed
1 task
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 26, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 651fb1c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gwansikk gwansikk requested a review from Jeong-Ag May 26, 2024 12:48
Jeong-Ag
Jeong-Ag approved these changes May 26, 2024
View reviewed changes
Copy link
Contributor

@Jeong-Ag Jeong-Ag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

무한스크롤과 스켈레톤으로 더 좋은 UI가 구성된 것 같아요. 수고많으셨습니다!

apps/member/src/components/common/Skeleton/Skeleton.tsx Outdated Show resolved Hide resolved
apps/member/src/components/community/Board/BoardSkeleton.tsx Outdated Show resolved Hide resolved
@gwansikk gwansikk requested a review from Jeong-Ag May 26, 2024 14:53
@gwansikk gwansikk merged commit 417c9fc into main May 26, 2024
4 checks passed
@gwansikk gwansikk deleted the refactor/#147 branch May 26, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeong-Ag Jeong-Ag Awaiting requested review from Jeong-Ag Jeong-Ag is a code owner

Assignees

@gwansikk gwansikk

Labels
🏠 Member member 프로젝트 관련 🔨 Refactor 코드 수정 및 최적화
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Member] 커뮤니티 게시글 댓글 표시
2 participants
@gwansikk @Jeong-Ag