Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimal proposal #3

Open
wants to merge 36 commits into
base: add-tables-points
Choose a base branch
from
Open

Minimal proposal #3

wants to merge 36 commits into from
+3,241 −307

Commits on May 26, 2023

  1. First attempt at draft alternative proposal for the table spec

    @minnerbe
    minnerbe committed May 26, 2023
    Configuration menu
    Copy the full SHA
    c761555 View commit details
    Browse the repository at this point in the history

  2. Fix a few things after reviewing the spec

    @minnerbe
    minnerbe committed May 26, 2023
    Configuration menu
    Copy the full SHA
    27d1d2c View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2023

  1. First draft of minimal table spec

    @minnerbe
    minnerbe committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    d61a9e1 View commit details
    Browse the repository at this point in the history

  2. Include suggestions by @d-v-b

    @minnerbe
    minnerbe committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    3d38a15 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2023

  1. overhaul tables section introduction text

    @virginiascarlett
    virginiascarlett committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    ea990e8 View commit details
    Browse the repository at this point in the history

  2. start messing around with tables tree diagram

    @virginiascarlett
    virginiascarlett committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    0b3b652 View commit details
    Browse the repository at this point in the history

  3. augment and clarify tables introduction

    @virginiascarlett
    virginiascarlett committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    0f58543 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2023

  1. Homogenize dimension requirement for columns

    @minnerbe
    minnerbe committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    eef3b3e View commit details
    Browse the repository at this point in the history

  2. Homogenize appearance of zarr structure

    @minnerbe
    minnerbe committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    e864782 View commit details
    Browse the repository at this point in the history

  3. Add improvements based on discussion with @virginiascarlett

    @minnerbe
    minnerbe committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    2d6f153 View commit details
    Browse the repository at this point in the history

  4. clarify purpose of annotations

    @virginiascarlett
    virginiascarlett committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    4462547 View commit details
    Browse the repository at this point in the history

  5. update first tables paragraph

    @virginiascarlett
    virginiascarlett committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    d794f22 View commit details
    Browse the repository at this point in the history

  6. change tables section title

    @virginiascarlett
    virginiascarlett committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    dd9ece8 View commit details
    Browse the repository at this point in the history

  7. add backticks around the word tables/

    @virginiascarlett
    virginiascarlett committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    5d6cf99 View commit details
    Browse the repository at this point in the history

  8. update index.html

    @virginiascarlett
    virginiascarlett committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    2639d9e View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2023

  1. change the second sentence of Tables section a tiny bit

    @virginiascarlett
    virginiascarlett committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    f46d53e View commit details
    Browse the repository at this point in the history

  2. process index.bs to index.html

    @virginiascarlett
    virginiascarlett committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    332e44d View commit details
    Browse the repository at this point in the history

  3. change one word: AnnData table to array, and process html

    @virginiascarlett
    virginiascarlett committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    e717f4b View commit details
    Browse the repository at this point in the history

  4. Fix correction and clarify dimensions of annotated-data property

    @minnerbe
    minnerbe committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    b8190ba View commit details
    Browse the repository at this point in the history

  5. Make dimensionality of columns more concrete

    @minnerbe
    minnerbe committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    5a26ad7 View commit details
    Browse the repository at this point in the history

  6. Add statement about rows

    @minnerbe
    minnerbe committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    56560ac View commit details
    Browse the repository at this point in the history

  7. Add html file changes

    @minnerbe
    minnerbe committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    768cf1b View commit details
    Browse the repository at this point in the history

  8. separate the cases of tables annotating images vs. annotating other t… 

    …ables
    @virginiascarlett
    virginiascarlett committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    f6dbaa5 View commit details
    Browse the repository at this point in the history

  9. update html

    @virginiascarlett
    virginiascarlett committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    77dada0 View commit details
    Browse the repository at this point in the history

  10. no one will ever want to annotate a column

    @virginiascarlett
    virginiascarlett committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    b65ebcd View commit details
    Browse the repository at this point in the history

  11. remove a newline

    @virginiascarlett
    virginiascarlett committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    8a45a5b View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2023

  1. Add a file showing how anndata could be stored

    @minnerbe
    minnerbe committed Jun 25, 2023
    Configuration menu
    Copy the full SHA
    9b08825 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2023

  1. List tables in metadata (as suggested by @will-moore)

    @minnerbe
    minnerbe committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    15c9a20 View commit details
    Browse the repository at this point in the history

  2. Change row name representation 

    As suggested by @will-moore and @virginiascarlett:
* Change SHOULD to MAY
* Add metadata attribute to specify column containing row names
    @minnerbe
    minnerbe committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    75e8b01 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. clarify language in first paragraph of tables section

    @virginiascarlett
    virginiascarlett committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    550cfe7 View commit details
    Browse the repository at this point in the history

  2. explain the three properties in tables/table1/.zattrs

    @virginiascarlett
    virginiascarlett committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    997b930 View commit details
    Browse the repository at this point in the history

  3. remove row_names from tables diagram

    @virginiascarlett
    virginiascarlett committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    03034b3 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. Fix spurious bracket in some link

    @minnerbe
    minnerbe committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    09e1a5c View commit details
    Browse the repository at this point in the history

  2. Fix <img/> element for newer bikeshed versions 

    Apparently a new release of bikeshed is now unhappy with the use of
`<img/>` and `<img></img>` is required:

```
  $ bikeshed spec "latest/index.bs" "latest/index.out.html"
  LINE 651:1: Tag <img> wasn't closed at end of file.
   ✘  Did not generate, due to fatal errors

  Failed
```
    @joshmoore @mkitti
    joshmoore authored and mkitti committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    126be88 View commit details
    Browse the repository at this point in the history

  3. Fix JSON comments in tables

    @mkitti
    mkitti committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    f3295b7 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #1 from mkitti/mkitti/minimal-proposal-fixes 

    Fix img and JSON comments
    @minnerbe
    minnerbe authored Aug 28, 2023
    Configuration menu
    Copy the full SHA
    d63c147 View commit details
    Browse the repository at this point in the history