Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX BUG in load_weights_from_hdf5_group_by_name" legacy_h5_format.py #20537

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

edwardyehuang
Copy link
Contributor

@edwardyehuang edwardyehuang commented Nov 22, 2024

FIX #20536

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.59%. Comparing base (5d36ee1) to head (61144ed).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20537      +/-   ##
==========================================
- Coverage   82.15%   77.59%   -4.56%     
==========================================
  Files         515      515              
  Lines       47859    47859              
  Branches     7494     7494              
==========================================
- Hits        39317    37136    -2181     
- Misses       6730     8972    +2242     
+ Partials     1812     1751      -61     
Flag Coverage Δ
keras 77.45% <ø> (-4.55%) ⬇️
keras-jax 65.10% <ø> (ø)
keras-numpy ?
keras-tensorflow 66.08% <ø> (ø)
keras-torch 65.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the fix. Please add a unit test so we avoid breaking this in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG in load_weights_from_hdf5_group_by_name
4 participants