Embedded Magnet Option #207
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are two parameters that I would consider adding, please advise:
Also, there are some tests I need to fix, and probably a readme fix. |
EmperorArthur
requested changes
Aug 4, 2024
| @@ -253,6 +255,8 @@ module block_base_hole(hole_options, o=0) { | |||
| crush_ribs = hole_options[3]; | |||
| chamfer = hole_options[4]; | |||
| supportless = hole_options[5]; | |||
| embedded = hole_options[6]; | |||
| embedded_extra_layers = 3; | |||
There was a problem hiding this comment.
Could you please move this to the Magnet/Screw constants section of "standard.scad". That file is where all constant / magic values live.
| translate([-magnet_radius,-magnet_radius * 0.15,0]) | ||
| cube([2*magnet_radius, magnet_radius * 0.3, embedded_depth]); | ||
| cylinder(h = embedded_depth, r=magnet_radius); | ||
| } |
There was a problem hiding this comment.
Given this is inside a difference(), have you confirmed if this works correctly with other options? If it is not supposed to be used with anything else, then you will need to add checks similar to those which currently exist for refined_hole.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the embedded Magnet option. To use it, pause the printer like the Swedish Maker says. On a Bambu it's layer 12 right now. https://www.youtube.com/watch?v=p2bClWmKHRM&t=955s
The printer then prints around the part, and no glue is needed.