Added extraction feature.

kekyo · May 25, 2024 · be0631a · be0631a
1 parent 2f2580b
commit be0631a
Show file tree

Hide file tree

Showing 6 changed files with 148 additions and 24 deletions.
diff --git a/chibiar/chibiar.core.Tests/ArchiverTests.cs b/chibiar/chibiar.core.Tests/ArchiverTests.cs
@@ -7,15 +7,16 @@
 //
 /////////////////////////////////////////////////////////////////////////////////////
 
+using chibicc.toolchain.Archiving;
+using chibicc.toolchain.Logging;
 using NUnit.Framework;
 using System;
 using System.IO;
 using System.IO.Compression;
 using System.Linq;
 using System.Text;
 using System.Threading.Tasks;
-using chibicc.toolchain.Archiving;
-using chibicc.toolchain.Logging;
+
 using static VerifyNUnit.Verifier;
 using static chibiar.ArchiverTestRunner;
 
@@ -51,6 +52,7 @@ public Task ArchiveOne()
                 {
                     Path.Combine(ArtifactsBasePath, "parse.o"),
                 },
+                true,
                 false);
             
             Assert.That(actual, Is.True);
@@ -80,6 +82,7 @@ public Task ArchiveTwo()
                     Path.Combine(ArtifactsBasePath, "parse.o"),
                     Path.Combine(ArtifactsBasePath, "codegen.o"),
                 },
+                true,
                 false);
             
             Assert.That(actual, Is.True);
@@ -116,6 +119,7 @@ public Task Update()
                     Path.Combine(ArtifactsBasePath, "parse.o"),
                     Path.Combine(ArtifactsBasePath, "codegen.o"),
                 },
+                true,
                 false);
             
             Assert.That(actual1, Is.True);
@@ -126,6 +130,7 @@ public Task Update()
                 {
                     newCodegenPath,
                 },
+                true,
                 false);
             
             Assert.That(actual2, Is.False);

diff --git a/chibiar/chibiar.core/Archiver.cs b/chibiar/chibiar.core/Archiver.cs
@@ -8,6 +8,7 @@
 /////////////////////////////////////////////////////////////////////////////////////
 
 using System;
+using System.Collections.Generic;
 using System.IO;
 using System.IO.Compression;
 using System.Linq;
@@ -146,14 +147,18 @@ private static SymbolList[] GetSymbolLists(
             Parallel.ForEach(objectNames,
                 (objectName, _, index) =>
                 {
-                    using var stream = ArchiverUtilities.OpenArchivedObject(
+                    if (ArchiverUtilities.TryOpenArchivedObject(
                         archiveFilePath,
-                        objectName);
-                
-                    var symbols = ArchiverUtilities.EnumerateSymbolsFromObjectFile(stream).
-                        ToArray();
+                        objectName,
+                        out var stream))
+                    {
+                        using var _s = stream;
+                        
+                        var symbols = ArchiverUtilities.EnumerateSymbolsFromObjectFile(stream).
+                            ToArray();
 
-                    symbolLists[index] = new(objectName, symbols);
+                        symbolLists[index] = new(objectName, symbols);
+                    }
                 });
         }
         else
@@ -196,6 +201,7 @@ private static void AddSymbolTable(
     internal bool AddOrUpdate(
         string archiveFilePath,
         string[] objectFilePaths,
+        bool isCreateSymbolTable,
         bool isDryrun)
     {
         var isCreatedArchive = !File.Exists(archiveFilePath);
@@ -211,28 +217,98 @@ internal bool AddOrUpdate(
             objectNames,
             isDryrun);
 
-        AddSymbolTable(
-            archiveFilePath,
-            symbolLists,
-            isDryrun);
+        if (isCreateSymbolTable)
+        {
+            AddSymbolTable(
+                archiveFilePath,
+                symbolLists,
+                isDryrun);
+        }
 
         return isCreatedArchive;
     }
 
+    internal void Extract(
+        string archiveFilePath,
+        string[] objectNames,
+        bool isDryrun)
+    {
+        if (!isDryrun || File.Exists(archiveFilePath))
+        {
+            Parallel.ForEach(objectNames,
+                objectName =>
+                {
+                    if (ArchiverUtilities.TryOpenArchivedObject(
+                        archiveFilePath,
+                        objectName,
+                        out var inputStream))
+                    {
+                        using var outputStream = isDryrun ?
+                            new MemoryStream() :
+                            StreamUtilities.OpenStream(objectName, true);
+    
+                        inputStream.CopyTo(outputStream);
+                        outputStream.Flush();
+                    }
+                    else
+                    {
+                        this.logger.Error($"Object is not found: {objectName}");
+                    }
+                });
+        }
+    }
+
+    internal void List(
+        string archiveFilePath,
+        string[] objectNames)
+    {
+        if (objectNames.Length >= 1)
+        {
+            var existObjectNames = new HashSet<string>(
+                ArchiverUtilities.EnumerateArchivedObjectNames(archiveFilePath));
+
+            foreach (var objectName in objectNames.
+                Where(existObjectNames.Contains))
+            {
+                Console.WriteLine(objectName);
+            }
+        }
+        else
+        {
+            foreach (var objectName in
+                ArchiverUtilities.EnumerateArchivedObjectNames(archiveFilePath))
+            {
+                Console.WriteLine(objectName);
+            }
+        }
+    }
+
     public void Archive(CliOptions options)
     {
         switch (options.Mode)
         {
             case ArchiveModes.AddOrUpdate:
                 if (this.AddOrUpdate(
                     options.ArchiveFilePath,
-                    options.ObjectFilePaths.ToArray(),
+                    options.ObjectNames.ToArray(),
+                    options.IsCreateSymbolTable,
                     options.IsDryRun) &&
                     !options.IsSilent)
                 {
                     this.logger.Information($"creating {Path.GetFileName(options.ArchiveFilePath)}");
                 }
                 break;
+            case ArchiveModes.Extract:
+                this.Extract(
+                    options.ArchiveFilePath,
+                    options.ObjectNames.ToArray(),
+                    options.IsDryRun);
+                break;
+            case ArchiveModes.List:
+                this.List(
+                    options.ArchiveFilePath,
+                    options.ObjectNames.ToArray());
+                break;
             default:
                 throw new NotImplementedException();
         }

diff --git a/chibiar/chibiar.core/Cli/CliOptions.cs b/chibiar/chibiar.core/Cli/CliOptions.cs
@@ -18,6 +18,7 @@ public enum ArchiveModes
 {
     Nothing,
     AddOrUpdate,
+    Extract,
     Delete,
     List,
 }
@@ -27,10 +28,11 @@ public sealed class CliOptions
     public string ArchiveFilePath = null!;
     public ArchiveModes Mode = ArchiveModes.Nothing;
     public bool IsSilent = false;
+    public bool IsCreateSymbolTable = true;
     public bool IsDryRun = false;
     public LogLevels LogLevel = LogLevels.Warning;
     public bool ShowHelp = false;
-    public readonly List<string> ObjectFilePaths = new();
+    public readonly List<string> ObjectNames = new();
 
     private CliOptions()
     {
@@ -60,6 +62,9 @@ public static CliOptions Parse(string[] args)
                     case 'u':
                         options.Mode = ArchiveModes.AddOrUpdate;
                         break;
+                    case 'x':
+                        options.Mode = ArchiveModes.Extract;
+                        break;
                     case 'd':
                         options.Mode = ArchiveModes.Delete;
                         break;
@@ -70,6 +75,10 @@ public static CliOptions Parse(string[] args)
                         options.IsSilent = true;
                         break;
                     case 's':
+                        options.IsCreateSymbolTable = true;
+                        break;
+                    case 'S':
+                        options.IsCreateSymbolTable = false;
                         break;
                     case 'h':
                         options.ShowHelp = true;
@@ -125,7 +134,7 @@ public static CliOptions Parse(string[] args)
 
         for (var index = 2; index < args.Length; index++)
         {
-            options.ObjectFilePaths.Add(Path.GetFullPath(args[index]));
+            options.ObjectNames.Add(args[index]);
         }
 
         return options;
@@ -134,9 +143,11 @@ public static CliOptions Parse(string[] args)
     public static void WriteUsage(TextWriter tw)
     {
         tw.WriteLine("  -r, -u            Add or update object files into the archive");
-        tw.WriteLine("  -c                Add object files into the archive silently");
-        tw.WriteLine("  -s                Add symbol table (Always enabled)");
+        tw.WriteLine("  -c                Create archive file silently");
+        tw.WriteLine("  -x                Extract object files from the archive");
         tw.WriteLine("  -d                Delete object files from the archive");
+        tw.WriteLine("  -s                Add symbol table (default)");
+        tw.WriteLine("  -S                Will not add symbol table");
         tw.WriteLine("  -t                List object files in the archive");
         tw.WriteLine("      --log <level> Log level [debug|trace|information|warning|error|silent] (defaulted: warning)");
         tw.WriteLine("      --dryrun      Need to dryrun");

diff --git a/chibiar/chibiar/Program.cs b/chibiar/chibiar/Program.cs
@@ -19,11 +19,13 @@ public static class Program
 {
     public static int Main(string[] args)
     {
+        Console.WriteLine($"chibiar: {string.Join(" ", args)}");
+
         try
         {
             var options = CliOptions.Parse(args);
 
-            if (options.ShowHelp || options.ObjectFilePaths.Count == 0)
+            if (options.ShowHelp)
             {
                 Console.WriteLine();
                 Console.WriteLine($"cil-ecma-chibiar [{ThisAssembly.AssemblyVersion},{ThisAssembly.AssemblyMetadata.TargetFrameworkMoniker}] [{ThisAssembly.AssemblyMetadata.CommitId}]");

diff --git a/chibild/chibild.core/Generating/ArchivedObjectInputFragment.cs b/chibild/chibild.core/Generating/ArchivedObjectInputFragment.cs
@@ -7,6 +7,7 @@
 //
 /////////////////////////////////////////////////////////////////////////////////////
 
+using System;
 using chibicc.toolchain.Archiving;
 using chibicc.toolchain.Parsing;
 using chibicc.toolchain.Logging;
@@ -179,9 +180,17 @@ public LoadObjectResults LoadObjectIfRequired(
         {
             logger.Information($"Loading: {this.ObjectPath}");
 
-            using var stream = ArchiverUtilities.OpenArchivedObject(
+            if (!ArchiverUtilities.TryOpenArchivedObject(
                 Path.Combine(this.BaseInputPath, this.RelativePath),
-                this.archivedObjectName);
+                this.archivedObjectName,
+                out var stream))
+            {
+                logger.Error(
+                    $"Unable find an object on archive: ObjectName={this.archivedObjectName}, ArchiveFile={this.RelativePath}");
+                return LoadObjectResults.CaughtError;
+            }
+
+            using var _s = stream;
             var tr = new StreamReader(stream, Encoding.UTF8, true);
 
             var parser = new CilParser(logger);

diff --git a/toolchain.common/Archiving/ArchiverUtilities.cs b/toolchain.common/Archiving/ArchiverUtilities.cs
@@ -7,6 +7,7 @@
 //
 /////////////////////////////////////////////////////////////////////////////////////
 
+using System;
 using chibicc.toolchain.Internal;
 using chibicc.toolchain.Parsing;
 using chibicc.toolchain.Tokenizing;
@@ -235,16 +236,36 @@ public static IEnumerable<string> EnumerateArchivedObjectNames(
         }
     }
 
-    public static Stream OpenArchivedObject(string archiveFilePath, string objectName)
+    public static bool TryOpenArchivedObject(
+        string archiveFilePath,
+        string objectName,
+        out Stream stream)
     {
         var archive = ZipFile.Open(
             archiveFilePath,
             ZipArchiveMode.Read,
             Encoding.UTF8);
 
-        var zs = archive.GetEntry(objectName)!.Open();
-        var ofs = new GZipStream(zs, CompressionMode.Decompress);
+        try
+        {
+            if (archive.GetEntry(objectName) is { } entry)
+            {
+                var ofs = new GZipStream(entry.Open(), CompressionMode.Decompress);
 
-        return new ArchiveObjectStream(archive, ofs);
+                stream = new ArchiveObjectStream(archive, ofs);
+                return true;
+            }
+            else
+            {
+                archive.Dispose();
+                stream = null!;
+                return false;
+            }
+        }
+        catch
+        {
+            archive.Dispose();
+            throw;
+        }
     }
 }