Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): more verbose #2695

Merged
merged 1 commit into from
Nov 28, 2024
Merged

feat(api): more verbose #2695

merged 1 commit into from
Nov 28, 2024

Conversation

shahargl
Copy link
Member

close #2694

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 28, 2024
Copy link

vercel bot commented Nov 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Nov 28, 2024 7:31pm

@dosubot dosubot bot added API API related issues Feature A new feature labels Nov 28, 2024
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lfg

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 28, 2024
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 53.57143% with 13 lines in your changes missing coverage. Please review.

Project coverage is 44.15%. Comparing base (613effa) to head (780ab24).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
keep/api/routes/alerts.py 10.00% 9 Missing ⚠️
keep/api/core/dependencies.py 0.00% 2 Missing ⚠️
keep/api/tasks/process_event_task.py 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2695      +/-   ##
==========================================
- Coverage   44.22%   44.15%   -0.07%     
==========================================
  Files         156      158       +2     
  Lines       14812    14965     +153     
==========================================
+ Hits         6550     6608      +58     
- Misses       8262     8357      +95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shahargl shahargl merged commit b92b470 into main Nov 28, 2024
13 of 14 checks passed
@shahargl shahargl deleted the feat/verbose2 branch November 28, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API API related issues Feature A new feature lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[➕ Feature]: add verbosity
2 participants