Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: switch all alert queries to use lastalert (dnm) #2638

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

feat: switch all alert queries to use lastalert (dnm) #2638

wants to merge 25 commits into from

Conversation

VladimirFilonov
Copy link
Contributor

Closes #2623
DNM before: #2473

📑 Description

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@vercel Vercel
Copy link

vercel bot commented Nov 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Nov 26, 2024 8:41am

@VladimirFilonov VladimirFilonov changed the title Feature/2623 switch all alert queries to use lastalert (dnm) feat: switch all alert queries to use lastalert (dnm) Nov 26, 2024
@VladimirFilonov VladimirFilonov force-pushed the feature/2623-switch-all-alert-queries-to-use-lastalert branch from fbcd17d to 842d249 Compare November 26, 2024 08:05
VladimirFilonov and others added 25 commits November 26, 2024 12:40
@VladimirFilonov
Add LastAlert and LastAlertToIncident and adjust incidents logic to it
9371a0c
@VladimirFilonov
Fix some uncovered issues
d2d299f
@VladimirFilonov
Remove unused imports and lost usages of AlertToIncident
7729cf0
@VladimirFilonov
Fix incident test and joining logic in get_last_alerts
946bacc
@VladimirFilonov
Fix typo
20627ff
@VladimirFilonov
Return group by to incidents_subquery
fd55a15
@VladimirFilonov
Fix creation of lastalerts in setup_stress_alerts_no_elastic
cf54747
@VladimirFilonov
Update existed LastAlerts in setup_stress_alerts_no_elastic
5ca2abe
@VladimirFilonov
Fix typo
1eddfb3
@VladimirFilonov
Fix migration docs
71ab9bd
@VladimirFilonov
More explicit if condition
68da604
@VladimirFilonov
Remove unused imports
75694ff
@VladimirFilonov
Add LastAlert and LastAlertToIncident and adjust incidents logic to it
bb4cd79
@VladimirFilonov
Fix some uncovered issues
700cbc4
@VladimirFilonov
Remove unused imports and lost usages of AlertToIncident
826c5fb
@VladimirFilonov
Fix incident test and joining logic in get_last_alerts
d076ecd
@VladimirFilonov
Remove unused imports
1dd95ae
@VladimirFilonov @Kiryous
Update keep/api/core/db.py
f96ace7 
Co-authored-by: Kirill Chernakov <[email protected]>
Signed-off-by: Vladimir Filonov <[email protected]>
@VladimirFilonov
Fix foreign key in lastalerttoincident for complex primary key in las…
76e8bfd 
…talert
@VladimirFilonov
Fix groupping in Rule histogram query and migaration deps
d512f4c
@VladimirFilonov
LastAlert.tenant_id should be primary key not only in migration
dd72fce
@VladimirFilonov
Clean up FKs and indexes for lastalert
0b3e423
@VladimirFilonov
Add first_timestamp to LastAlert to simplify min/max timestamp operat…
4dd0cdc 
…ions
@VladimirFilonov
Switch from using Alert to LastAlert in get_alerts_* db methods
4c0d2bf
@VladimirFilonov
Fix query usage in session
5c3b106
@VladimirFilonov VladimirFilonov force-pushed the feature/2623-switch-all-alert-queries-to-use-lastalert branch from 842d249 to 5c3b106 Compare November 26, 2024 08:41
@VladimirFilonov VladimirFilonov marked this pull request as ready for review November 26, 2024 08:51
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. Feature A new feature labels Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Feature A new feature size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[➕ Feature]: Switch all Alert queries to use LastAlert
1 participant
@VladimirFilonov