fix:Add Type Safety and Validation for Provider Inputs #2353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rishisulakhe is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
dosubot
bot
added
size:L
rishisulakhe
changed the title
talboren
requested changes
Nov 1, 2024
There was a problem hiding this comment.
Hey @rishisulakhe, thank you for the contribution.
a few small things:
- Can you please make sure you follow PR guidelines?: fix PR name, make sure tests pass and add a video of what’s changed.
- Explain why not using zod simply and what’s the motivation
|
Closing this for now, @rishisulakhe if this is still relevant please feel free to re-open it. 🙏🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/claim #1327
/closes #1327
Description of PR: