Update makefile to pin pip version to fix nightly CI

[noklam]

NOTE: Kedro datasets are moving from kedro.extras.datasets to a separate kedro-datasets package in
kedro-plugins repository. Any changes to the dataset implementations
should be done by opening a pull request in that repository.

Description

pypa/pip#12317

pip 23.2 breaks Python <3.8 and we have pin it in environment.py, now pip 23.3 breaks the dependency resolution.

See full log here: https://github.com/kedro-org/kedro/actions/runs/6527279214/job/17743502460

The conflict is caused by:
kedro[test] 0.18.13 depends on dask~=2021.10; extra == "test"
dask[complete] 2021.12.0 depends on dask 2021.12.0 (from https://files.pythonhosted.org/packages/15/6d/99c63be3ea8a4a651d845addeea1f1b3bb8e5c6730bc26cfb6176631adf7/dask-2021.12.0-py3-none-any.whl (from https://pypi.org/simple/dask/) (requires-python:>=3.7))

The conflict does not exist and this is because pip switch the backend for dependency resolver.

Development notes

Cause: pip 23.2 or 23.3 used a new backend for dependency resolver and it’s buggy.

Changes:
Pin pip <23.2 for all Python versions (used to be specific one due to pip-tools)
Change .readthedoc.yml - this one is rather hacky but because RTD has a very rigid build steps that cannot be overrided.

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

• Read the contributing guidelines
• Signed off each commit with a Developer Certificate of Origin (DCO)
• Opened this PR as a 'Draft Pull Request' if it is work-in-progress
• Updated the documentation to reflect the code changes
• Added a description of this change in the RELEASE.md file
• Added tests to cover my changes
• Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

[ankatiyar]

@noklam Might also need to pin the pip version for rtd build!

[noklam]

https://docs.readthedocs.io/en/stable/config-file/v2.html
It isn’t exactly clear where did RTD inject those command, I am trying to use pre_install now.

post_checkout, pre_system_dependencies, post_system_dependencies, pre_create_environment, post_create_environment, pre_install, post_install, pre_build, post_build

I am trying to move everything to pre_install and abandon the install steps because RTD always upgrade pip if we choose to install requirements.txt, which is causing the failure.

[noklam]

Appear to be working, I have added some comments there. This is quite hacky and we should remove it when pip release a better version.

[ankatiyar]

Thank you @noklam for the super quick fix! 💯

[astrojuanlu]

🚀

[notatallshaw]

Do you have a small reproducible example of where newer versions of Pip fail?

I want to check if it's really the same issue as the one you link, and have an additional test case for when there is a fix.

[notatallshaw]

FYI, after some investigating I do not beleive the issue you linked to (pypa/pip#12317) triggers this issue, I have created a new issue on Pip for this error: pypa/pip#12376