✨ Bootstrap code with kubebuilder and set up initial CRDs #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On-behalf-of: @SAP [email protected] Signed-off-by: Marvin Beckers <[email protected]>
kcp-ci-bot
added
do-not-merge/work-in-progress
embik
changed the title
kcp-ci-bot
added
release-note
embik
changed the title
kcp-ci-bot
added
the
do-not-merge/work-in-progress
On-behalf-of: @SAP [email protected] Signed-off-by: Marvin Beckers <[email protected]>
On-behalf-of: @SAP [email protected] Signed-off-by: Marvin Beckers <[email protected]>
embik
force-pushed
the
bootstrap-code
branch
from
50077c8
to
26d0bc9
Compare
embik
changed the title
kcp-ci-bot
removed
the
do-not-merge/work-in-progress
embik
force-pushed
the
bootstrap-code
branch
from
bdc0ec4
to
1d5728d
Compare
On-behalf-of: @SAP [email protected] Signed-off-by: Marvin Beckers <[email protected]>
embik
force-pushed
the
bootstrap-code
branch
2 times, most recently
from
068aba9
to
dc30b02
Compare
On-behalf-of: @SAP [email protected] Signed-off-by: Marvin Beckers <[email protected]>
embik
force-pushed
the
bootstrap-code
branch
from
dc30b02
to
b690ca6
Compare
|
@embik: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
On-behalf-of: @SAP [email protected] Signed-off-by: Marvin Beckers <[email protected]>
embik
force-pushed
the
bootstrap-code
branch
from
b690ca6
to
ebc3255
Compare
mjudeikis
approved these changes
Nov 20, 2024
| RunSpecs(t, "Controller Suite") | ||
| } | ||
|
|
||
| var _ = BeforeSuite(func() { |
There was a problem hiding this comment.
Is ginko something we really want to go with? :D I would prefer something more like kcp framework. Wondering what others thing?
There was a problem hiding this comment.
This is bootstrapped by kubebuilder. I'm open to changing it once we implement real tests, I'd just leave it in for now.
|
LGTM label has been added. Git tree hash: b47f572868b53aefecc6bf3f0e7abccd2e00d7be
|
On-behalf-of: @SAP [email protected] Signed-off-by: Marvin Beckers <[email protected]>
embik
force-pushed
the
bootstrap-code
branch
from
f36fc62
to
a3487f8
Compare
|
/lgtm |
|
LGTM label has been added. Git tree hash: d21a0efd7f86e01059f7040d44f7f95fe9e054d9
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mjudeikis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds an initial scaffold via kubebuilder. It's big as it stands, so I'm not adding anything more.
Core focus of the review (i.e. the only things I changed) should be the
apis/directory. I've written some simple documentation for how objects relate to each other as well.Related issue(s)
Fixes #
Release Notes